Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore enabling TS Server plugins on serverless #140455

Closed
mjbvz opened this issue Jan 10, 2022 · 1 comment · Fixed by microsoft/TypeScript#47377 or #149186
Closed

Explore enabling TS Server plugins on serverless #140455

mjbvz opened this issue Jan 10, 2022 · 1 comment · Fixed by microsoft/TypeScript#47377 or #149186
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders typescript Typescript support issues upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Jan 10, 2022

Tracks seeing if we can run TS Server plugins on serverless web

@mjbvz mjbvz added this to the January 2022 milestone Jan 10, 2022
@mjbvz mjbvz self-assigned this Jan 10, 2022
mjbvz added a commit that referenced this issue Jan 11, 2022
For #140455

This does not actually enable this feature but a first step for it. Requires work on the TS side to actually get working
mjbvz added a commit to mjbvz/TypeScript that referenced this issue Jan 11, 2022
This is a first exploration for  microsoft#47376 microsoft/vscode#140455

It implements a very basic version of `require` for the web that lets us load plugins with a very specific structure. `require` being sync limits our options here, so I'm using `importScripts` plus a global to get the exports of a plugin. The plugin must also be compiled down to a single file at the moment
@mjbvz mjbvz added the typescript Typescript support issues label Jan 11, 2022
@mjbvz mjbvz modified the milestones: January 2022, February 2022 Jan 19, 2022
@mjbvz mjbvz modified the milestones: February 2022, March 2022 Feb 22, 2022
@mjbvz mjbvz modified the milestones: March 2022, April 2022 Mar 21, 2022
@mjbvz mjbvz added the upstream-issue-linked This is an upstream issue that has been reported upstream label Apr 15, 2022
@mjbvz mjbvz modified the milestones: April 2022, May 2022 Apr 19, 2022
@mjbvz mjbvz changed the title Explore enabling TS Server plugins on in serverless Explore enabling TS Server plugins on serverless May 23, 2022
@mjbvz mjbvz modified the milestones: May 2022, June 2022 May 24, 2022
@mjbvz mjbvz modified the milestones: June 2022, August 2022 Jun 16, 2022
@mjbvz
Copy link
Contributor Author

mjbvz commented Aug 2, 2022

Fixed by #149186

@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders typescript Typescript support issues upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
2 participants