Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test new cell fold/collapse features #141222

Closed
3 tasks done
roblourens opened this issue Jan 22, 2022 · 1 comment
Closed
3 tasks done

Test new cell fold/collapse features #141222

roblourens opened this issue Jan 22, 2022 · 1 comment

Comments

@roblourens
Copy link
Member

roblourens commented Jan 22, 2022

Refs: #132690

Complexity: 3

Create Issue


Open any notebook using any notebook provider. For example, install the "Github Issue Notebooks" extension and open one of the *.github-issues files in the vscode repo.

  • Make sure you have "notebook.cellFocusIndicator": "gutter" (the default)
  • You should now be able to click the blue bar to collapse the cell input or output
  • The collapsing feature existed before via double-clicking or the context menu, the blue bar behavior is new
  • When the cell has output, the blue bar is split and clicking the top half should just collapse the input, the bottom half should just collapse the output
  • Try different notebook layout settings and make sure that the bar still appears and works correctly
  • It also works to collapse markdown cells and doesn't appear split

  • When you fold a markdown cell (by clicking the chevron), text like "X cells hidden..." appears
  • Try with different notebook layout settings and make sure that the layout appears correct, e.g. that text is not overflowing onto the next cell

Note that "collapsing" in the first item is different from "folding" in the second. Code and Markdown cells can be collapsed, and this just reduces their height to about one line. Folding folds hierarchical groups of markdown cells.

Known issues

  • Fold/unfolding a markdown cell can sometimes produce flickering in markdown cells below
  • The ... will become clickable to expand the folded region
@joaomoreno
Copy link
Member

All I got is nitpicking.

It's hard to click the indicator, especially if the only open file is the notebook itself: the indicator is right next to the window's resizeable border.


I found the style of a collapsed Markdown cell very confusing: it just looks like an uncolored version of a Markdown cell in edit mode... but double clicking it does nothing.

image

image


I find the 1 cell hidden... indicator strange. I'm not sure the ... is conveying anything there. At best, let's use an ellipsis .

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants