Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't see that a code cell is collapsed #141579

Closed
Tracked by #142690
kieferrm opened this issue Jan 26, 2022 · 6 comments
Closed
Tracked by #142690

Can't see that a code cell is collapsed #141579

kieferrm opened this issue Jan 26, 2022 · 6 comments
Assignees
@roblourens @rebornix
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-layout verified Verification succeeded
Milestone
February 2022

Comments

@kieferrm
Copy link
Member

Testing #141222.

When a code cell as a first line that causes a horizontal scrollbar and you collapse the cell, there is no visual indication anymore that the cell is collapsed.

image
@roblourens
Copy link
Member

Isn't it enough that you don't have the editor border/background color? If you hover, you will get a tooltip hint to double click. What else do you want to see?

@roblourens roblourens added the info-needed Issue requires more information from poster label Jan 26, 2022
@roblourens roblourens mentioned this issue Feb 10, 2022
Closed
5 tasks
@roblourens roblourens reopened this Feb 10, 2022
@roblourens roblourens added this to the February 2022 milestone Feb 10, 2022
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug notebook-layout and removed info-needed Issue requires more information from poster labels Feb 10, 2022
@roblourens
Copy link
Member

For reference - narrower cells get the ... button

image

@roblourens
Copy link
Member

We could

  • Make sure the ... is always visible - it would float to the right side
  • Show some other decoration, icon, or color to indicate that a cell is collapsed

mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue Feb 13, 2022
@roblourens @mustard-mh
Ensure input expand button is always shown for long code cell text. Fix
3d20537 
microsoft#141579
mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue Feb 13, 2022
@roblourens @mustard-mh
Ensure input expand button is always shown for long code cell text. Fix
0273272 
microsoft#141579
@joyceerhl joyceerhl added the verified Verification succeeded label Feb 25, 2022
@joyceerhl
Copy link
Contributor

The ... collapse indicator now does render for long code cell inputs. However the cell toolbar overlapping the cell input makes the rightmost area in the cell feel cramped. Has it always been this close to the cell input?
image

@roblourens
Copy link
Member

Yeah, but the alternative is adding more space between cells which I also don't want to do

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-layout verified Verification succeeded
Projects
None yet
Milestone
February 2022
Development

No branches or pull requests
5 participants
@roblourens @rebornix @kieferrm @joyceerhl and others