How can we move the new side panel to the right? #141349

noahehall · 2022-01-25T03:21:51Z

We use to be able to execute move panel right for moving the terminal panels to the right, however in the latest version of vscode (not sure where it started) that cmd has been deprecated, now we can only move the panel from the left side or docked on the bottom.

How can we move the panel to the right? im almost certain im doing something wrong

main content | terminal panels stacked vertically | explorer panels stacked vertically

the above UX is essential,

toggling the terminal/explorer does not cause the main content to jump around if the main content is flush left
on extra wide monitors you can effectively use the entire screen real estate

vscode error
Moving the panel with this command has been deprecated in favor of "Move Views From Panel To Side Panel" and "Move Views From Side Panel To Panel" for similar functionality.

The text was updated successfully, but these errors were encountered:

gjsjohnmurray · 2022-01-25T06:51:55Z

pinging @sbatten (bot made an assignment which surprised me)

sbatten · 2022-01-25T15:10:00Z

The new panel is limited to being placed opposite the side bar. I will leave this issue open to gather feedback.

hello-smile6 · 2022-02-04T01:01:53Z

@webdev03 Could you upvote? People deserve options.

ArturoDent · 2022-02-04T07:20:37Z

See https://stackoverflow.com/a/70982514/836330 for a partial "workaround" in the meantime.

gotofritz · 2022-02-04T09:10:54Z

As noted in #142075, these arbitrary changes are baffling in that they remove functionality we have been used to for years without solving any issue faced by users. It's unclear who decided on the changes and why, it looks like changing it for the sake of it. In more details

It is longer possible to have both the terminal and the sidebar to the right of the editor. Why? What problem is removing existing functionality supposed to solve?
When the terminal is in vertical view, it is no longer possible to make it full screen. Again, whose decision, and what problem were they trying to solve?
It is possible to move the "views" out of the "panel". Then CTRL-J will toggle the visibility of an empty "panel". What's the point of that? Who needs to view an empty panel?
Conversely, there is no shortcut to toggle the side panel visibility. Don't you collect metrics on how we use the editor? Hiding the terminal, editing code, showing the terminal again, sometimes maximised, sometimes not, it's what we do. All. Day. These changes completely destroy that. And to what benefit?
The abstractions are hard to understand and explain to the non initiated. The wording in the menu "Move views to panels" is too cryptc. "Panels"? "Views"? And "Sidebar" and "Side Panel" are too similar. As a user, why should I learn your jargon, and why should I care? The "panel" is an abstraction used by VSC developers. We users don't care about your implementation details, we care about concrete elements like the "Terminal". In fact we have a menu entry for "Terminal" but not one for "Panels"... As you probably know, the number 1 rule in UX is "don't make me think".
The menu entry "Terminal" in the menubar has always been associated with the terminal in the panel, now it opens a completely separate terminal in one of the document windows. Why? Why have two separate things doing the same thing? Why have the menu control only the one and not the other? You do understand how chaotic it all gets when you have terminals in the side panels, and terminals in the editor window, and you are trying to remember what is in which part of the IDE and which shortcut makes what panel appear... AAARGGH EDIT: as @gjsjohnmurray pointed out, this is something that can be changed in the preferences, and I had done so without knowing what it did

The whole design decision is a complete train wreck. I urge you to reconsider. Thanks.

gjsjohnmurray · 2022-02-04T09:37:41Z

Conversely, there is no shortcut to toggle the side panel visibility.

@gotofritz on this particular point I assume you know you can assign whatever shortcut suits you:

gjsjohnmurray · 2022-02-04T09:43:37Z

The menu entry "Terminal" in the menubar has always been associated with the terminal in the panel, now it opens a completely separate terminal in one of the document windows.

For me this only happens after I set "terminal.integrated.defaultLocation": "editor"

This capability arrived last year (see https://code.visualstudio.com/updates/v1_58#_terminals-in-the-editor-area).

gotofritz · 2022-02-04T09:47:54Z

Conversely, there is no shortcut to toggle the side panel visibility.

@gotofritz on this particular point I assume you know you can assign whatever shortcut suits you:

Yes of course. I wanted to flag that changing an existing shortcut to toggle a (potentially) empty panel, while the expected functionality is left to individual users to wire up manually in the preferences, is not ideal IMHO

gotofritz · 2022-02-04T09:50:09Z

The menu entry "Terminal" in the menubar has always been associated with the terminal in the panel, now it opens a completely separate terminal in one of the document windows.

For me this only happens after I set "terminal.integrated.defaultLocation": "editor"

This capability arrived last year (see https://code.visualstudio.com/updates/v1_58#_terminals-in-the-editor-area).

You are right, thanks for the tip... there are so many obscure terminal preferences settings that I may well have changed that manually in my desperate quest to bring back the old functionality

gjsjohnmurray · 2022-02-04T10:55:13Z

See https://stackoverflow.com/a/70982514/836330 for a partial "workaround" in the meantime.

Putting terminals in a dedicated editor group on one side could be improved by addressing this issue:

#16927 - Allow a maximized editor group to use the full width rather than leaving 220px per group for each of the other editor groups. Also make View: Toggle Editor Group Sizes and friends remember the original group splitbar position when maximizing a group, reinstating that when toggling back from maximized. Currently it resets to even distribution, in the same way double-clicking on the splitbar does.

adam-arold · 2022-02-04T11:50:57Z

@sbatten as I've stated elsewhere this is not a missing feature. It is a broken feature thus a breaking change in 1.64.0!

adam-arold · 2022-02-04T11:52:45Z

@webdev03 Could you upvote? People deserve options.

Upvoted, although this shouldn't be up for voting. This whole thing should be rolled back.

avianion · 2022-02-04T12:16:24Z

This is an absolute joke, how is it possible to make such a regression in your softwares functionality! This feature has been working for years.

gjsjohnmurray · 2022-02-04T12:30:35Z

Apparently no-one who uses that functionality does so with Insiders. Or if they do, I haven't seen an issue raised about it ahead of 1.64 shipping as Stable yesterday.

Workaround for the moment is to revert to 1.63. Installation links are at https://code.visualstudio.com/updates/v1_63 and you may also want to turn off update checks.

I am confident that the team (of which I am not a member) will be taking this feedback seriously.

carlfriedrich · 2022-02-04T12:42:11Z

I'd like to add some general and specific thoughts here.

General thoughts

In general, having an additional panel might be useful for some users. Adding such a new panel, however, should not break anyone's workflow who does NOT need another panel. In an ideal case, users who don't need it should not even recognize that it has been introduced. In a semi-ideal case, they should at least be able to re-configure their previous workflow in the new environment. Both cases are not true for the introcution of the side panel, which makes this a breaking change and should be announced accordingly, in my opinion.

Missed opportunities

I assume that the developers didn't put enough effort into evaluating existing workflows and maybe didn't even notice the impacts of this change. It could have easily been designed non-breaking, e.g. as follows:

Rename the existing "Panel" to "Primary Panel", keeping all functionality and keybindings as they are. This also affects all panel-related commands (e.g. View: Toggle Panel becomes View: Toggle Primary Panel). However, this is just a change of wording, no functional change.
Deprecate panel settings (e.g. workbench.panel.defaultLocation) in favour of updated ones (e.g. workbench.primaryPanel.defaultLocation), but keep them working for a defined number of releases.
Add a new general "Secondary Panel" with the same functionality as the existing panel.
Duplicate all panel settings for the seconday panel (e.g. workbench.secondaryPanel.defaultLocation).
Duplicate all existing panel commands, so that there is a version for the primary and one for the secondary panel (e.g. new command View: Toggle Secondary Panel).
Make the secondary panel be able to be placed at any location, just like the primary panel (left, right, top, bottom).

I don't see why the new side panel has been designed so different from the already existing panel. If I needed another panel, why force a specific layout? Who says I couldn't need two side panels? One at the left and one at the right? Or two bottom panels?

However, now that the new side panel has been introduced, it might be too late to design it this way, because that would make it another breaking change. I still think that this would be the most flexible, least surprising way, though.

The workaround

I don't think that the proposed "workaround" by putting the terminal into an editor group on the right side can replace previous workflows. The missing possibility to maximize the terminal has already been noted here. However, there are more limitations:

The terminal cannot be hidden. In order to hide it, one would have to close the editor group and open a new terminal, which is not the same.
There is no command to open another terminal in the same editor group. When having the terminal in the panel, this is possible using the Terminal: Create Terminal command.
- Running Terminal: Create Terminal while having a terminal open in an editor group opens the new terminal in the (side) panel.
- Running Terminal: Create New Terminal in Editor Area opens the terminal in the left-most editor-group, which is not the right one.
- Running Terminal: Create New Terminal in Editor Area to the Side opens the terminal in a new editor group, having both terminals side by side.
Splitting the terminal vertically does not work anymore. In the panel this can be done using the command Terminal: Split Terminal. When having a terminal open in an editor group, this creates a terminal in a new editor group on the right side.
The terminal cannot be resized using hotkeys. In the panel this is possible using the Terminal: Resize Terminal [Up/Left/Right/Down] commands. (As a side note, these commands do not work with the new side panel as well, which is already tracked in Resizing terminal inside side panel no longer works #142176).

Proposed steps

Taking into account all the above, I see two options in order to make previous workflows possible again:

The fix solution
- Do not tie the position of the vertical panel to the position of the side bar. Make it configurable independently, so that it can be on the left or on the right.
- Add a command View: Toggle Maximized Side Panel analogous to View: Toggle Maximized Panel (already tracked in toggleMaximizedPanel not working for side pannel #141569).
- Make the Terminal: Resize Terminal [Up/Left/Right/Down] commands work with the side panel again (see Resizing terminal inside side panel no longer works #142176, as already mentioned).
The clean solution
- Create a fix release (fast!) with the new side panel removed, restoring all previous functionality.
- Take the time to re-implement the side panel in the form of a secondary panel like proposed above under "Missed opportunities".

The bottom line

Of course the fix solution would be the easier one, but in my opinion it is far less sustainable as it bears the risk of future insonsistencies. From a developer's perspective, having two differently designed UI objects providing essentially the same functionality just leads to a higher maintenance effort due to more corner cases.

adam-arold · 2022-02-04T12:42:51Z

Apparently no-one who uses that functionality does so with Insiders. Or if they do, I haven't seen an issue raised about it ahead of 1.64 shipping as Stable yesterday.

I don't think that this is a valid criteria for introducing breaking changes. This is similar to the reasoning that was in The Hitchhiker's Guide to the Galaxy when the Vogons came to demolish Earth.

Oh, you were able to comment on this issue, it was on the Galactic Bulletin Board. (of course it didn't matter that humanity didn't know about the existence of the bulletin board nor had the tools to perform interstellar travel)

adam-arold · 2022-02-04T12:46:44Z

To give you a very specific example, this is what I can't do with 1.64.0:

Note that the Panel has 3 states: hidden, visible and maximized.

adam-arold · 2022-02-04T12:55:04Z

Note that #141569 is very closely related to this issue, in fact, that bug was introduced with the same change. If you vote for this please also vote for that.

martin-braun · 2022-02-10T16:44:51Z

It's unclear who decided on the changes and why, it looks like changing it for the sake of it.

@gotofritz No, it was not changed "for the sake of it". Removing the ability to move the panel to the right was an unfortunate side-effect introduced by #132893. In fact the ability to move the side-panel to the same side of the explorer panel was never removed, because this side-panel did not exist. The previous panel in the bottom was capable to be moved to the side but this concept was ditched and merged with the new side-panel and a mistake was made. As @sbatten pointed out, the new side-panel was limited to the opposite side of the explorer which introduced this issue.

adam-arold · 2022-02-10T18:46:24Z

I guess I'm switching to Atom now. Thanks for breaking your whole editor.

What the fluff, man. They just told us that it gets fixed in the next patch.

ArturoDent · 2022-02-10T21:32:21Z

I just received v1.64.2 which has this fix.

martin-braun · 2022-02-11T09:39:44Z

Thank you for the quick fix. 🙂

Unfortunately this fix only allows to move the bottom panel to the right, but I would also enjoy to move the new side panel to the same side like the explorer. #142819

h3d0 · 2022-02-11T10:22:18Z

I just wanted to share my expression and frustration of how bad the whole idea was. Have being using VSCdoe for 7+ years in my 12+ years developing experience. And this single change has been one of the most annoying in my whole IDE experience.

It simply broke my keybinds and the most used workflow in the middle of last 3 days of release. Why didn't you go further and add Left Panel, Right Panel, Top Panel and Bottom Panel. So we can have panels over the panels around code editor and move panels into panels.

This should be reverted completely and made an optional feature.

P.S. Changes like this - are core usability changes. They should be added as optional for those that need them. Not enforcing it to the whole community.

gjsjohnmurray · 2022-02-11T10:29:05Z

It simply broke my keybinds and the most used workflow in the middle of last 3 days of release.

@h3d0 maybe not a good time to have updated VS Code, particularly if you haven't also been using Insiders alongside Stable.

h3d0 · 2022-02-11T10:45:11Z

Thank you for the fix 1.62.2.

I am not really sure what is the difference between Panel (which can be put on the side/right) and Side Panel (on the side).

After the change the panels got messed up, also Ctrl+J my most-used keybind started producing new lines in Bash terminal (instead of toggling the Panel which was now Side Panel, because Panel could not be put at the side effectively).

After 1.62.2 I was able to:

Throw Side Panel into the unknown and forget about it.
Put all my things back into Panel and move Panel to the right like it was before.
Ctrl+J now correctly toggles Panel instead of producing new lines in Bash.

Everything is back to normal.

martin-braun · 2022-02-11T11:26:30Z

@h3d0 I can see how this caused some confusion in the first place. Please take a look at #26777 to see why the side panel was added, so things start to make sense to you hopefully. Overall it was a good change and I hope you can see it the same way.

The new side-panel is purely optional and you are able to continue to use VSCode like you did before, due to some reverting changes of 1.62.2 as you just figured out. The new side panel was never meant to be a replacement for your bottom panel that you've put to the right previously. It's meant for more flexibility, i.e. putting Outline on one side while having the Explorer on another and other useful scenarios.

adam-arold · 2022-02-12T21:10:40Z

I just wanted to share my expression and frustration of how bad the whole idea was. Have being using VSCdoe for 7+ years in my 12+ years developing experience. And this single change has been one of the most annoying in my whole IDE experience.

I totally agree with all your points, especially this one. I sat down one day to work on my project just to find that my workflow is totally broken. I've used dozens of editors throughout the years (Eclipse, Netbeans, Emacs, Idea, Vim, Notepad++ just to name a few) and this has never ever happened with any of them. I thought for a while that VS Code was the perfect editor. I no longer think that. The dream is dead.

The worst part is not that when I start it I can expect this to happen but how it was handled. No one from the team acknowledged that this was a mistake, no one apologized and no one came here and said sorry guys, we messed up, not gonna happen again.

I thought that Microsoft had very high standards, but apparently, they don't.

carlfriedrich · 2022-02-14T09:58:33Z

No one from the team acknowledged that this was a mistake, no one apologized and no one came here and said sorry guys, we messed up, not gonna happen again.

@adam-arold Well, that's not true. @sbatten did that, and he provided a fix for the issue.

And while I can understand any anger about this and Microsoft in general (I was annoyed by the change as well): let's not forget that the developers are still humans. Repeatedly posting how annoyed you are probably won't increase anyone's motivation to address your thoughts.

jsbrain · 2022-02-14T10:06:05Z

No one from the team acknowledged that this was a mistake, no one apologized and no one came here and said sorry guys, we messed up, not gonna happen again.

That is simply not true: #141349 (comment)

clytras · 2022-02-14T14:05:26Z

@adam-arold that's not fair. I think their response and actions were quite fast and everything is working as it was before now. And they actually did apologize to the users for this. To me, it looks like you have some generalized frustration towards Microsoft and their products. I actually thank every VSCode developer and contributor because they all made this amazing editor/IDE. And as stated above, we are humans and mistakes can happen and as long those mistakes get addressed and fixed it's fine; this is not a paid product, it's an open source project regardless if Microsoft may be having some of their developers to work on it.

Thank you @sbatten for working on this and fixing it.

gotofritz · 2022-02-14T14:59:25Z

Oh come on guys, it's true that @sbatten didn't cover himself in glory early on, but he learnt from his mistakes and the issue is now fixed (thanks!). Do we really need to keep going on about it? Maybe it's time to lock the thread....

heartacker · 2022-02-14T15:05:59Z

@gotofritz agree.

And let's look forward:

adam-arold · 2022-02-14T20:12:46Z

To me, it looks like you have some generalized frustration towards Microsoft and their products.

You're right, this might be the case. I stand corrected.

dewetblomerus · 2022-02-15T15:10:56Z

I complained on here as loud as I felt appropriate. After the fix came in I just wanted to come back and say thank you, and now I see people still piling on.

Software lesson: After convincing the devs that it's a bug and they need to fix it RIGHT NOW, and then they fix it, you look like you don't understand software when you then steer the conversation toward the feature that caused the bug. That feature is a separate conversation, that you probably don't understand if you are still complaining in this thread.

Life lesson: When a human makes a mistake and (after some dialogue) apologizes and fixes their mistake, it is insensitive, emotionally-tone-deaf, and probably inhumane to keep going on about what a bad idea it was.

fdiasr · 2022-02-15T15:17:07Z

Version 1.62.2 fixed the issue and it became available faster than any expectation, after show the situations.

Thanks yall involved.

adam-arold · 2022-02-16T18:29:44Z

Life lesson: When a human makes a mistake and (after some dialogue) apologizes and fixes their mistake, it is insensitive, emotionally-tone-deaf, and probably inhumane to keep going on about what a bad idea it was.

Or maybe the person in question has autism and you haven't considered that as an alternative to being insensitive, emotionally tone-deaf and inhumane.

liborty · 2022-02-23T04:29:05Z

How exactly is it fixed?
I still can not get the terminal to the left side like I used to have it for the life of me.
It insists on opening in the side panel on the right.
There are some 80 settings to do with the terminal and not one of them will do this simple thing.

P.S. Please do not tell me off for being insensitive for daring to complain about it.

martin-braun · 2022-02-23T14:49:10Z

@liborty have you read the comments please? :)

This issue was closed in favor of #142742 and #142832. I think this issue should be locked.

dewetblomerus · 2022-02-23T22:39:13Z

How exactly is it fixed? I still can not get the terminal to the left side like I used to have it for the life of me. It insists on opening in the side panel on the right. There are some 80 settings to do with the terminal and not one of them will do this simple thing.

P.S. Please do not tell me off for being insensitive for daring to complain about it.

I don't believe it is a setting. I would like it to be so I can default open the terminal in the same place across all environments. And you would be forgiven for spending your efforts looking in the settings because so many other things about the UI can be changed in settings.

Right-click toward the top of the terminal next to the tabs PROBLEMS, OUTPUT, etc, then you can choose Move Panel Right or Move Panel Left. If you don't see those options try Move Views to Panel and then those options should appear.

liborty · 2022-02-24T00:52:36Z

Thanks. I was stuck in catch 22. Those options were not showing because I did not activate them with "move views from side panel to panel". In the 'commands' rather than the 'settings' but also unrelated to the terminal. On the other hand, once I finally discovered this command, I now no longer need them.

In addition, the side panel mysteriously can not be moved because someone somewhere made an arbitrary rule about it having to be opposite the side bar, which of course the user does not know about. What a mess!

* debug: bump js-debug * Resources lost their authority part (fix microsoft#141328) * Run OSS tool * Enable resourceurls (microsoft#140709) * Enable resourceurls * Add selection to resourceurls from trees * Rename identifier * Respond to PR feedback * Do not loop opver openEditors * cleanup @vscode/windows-registry * Bump node-fetch from 2.6.2 to 2.6.7 (microsoft#141307) Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.2 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.2...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump node-fetch from 2.6.1 to 2.6.7 in /build (microsoft#141306) Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.1 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.1...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fixes microsoft#141392 * Add check that the editor's ESM JS files can be loaded in a browser * Create from template options for configure tasks Fixes microsoft#140867 * web - only simplify `vscode-remote` workspaces (microsoft#141411) * web - use correct untitled workspace object (fix microsoft#141411) * Install playwright using `npx playwright install` * Fix microsoft#141326 * Most recent -> last link Fixes microsoft#141419 * Add ellipsis to open detected link Fixes microsoft#141416 * $ref '' in 'http://json-schema.org/draft-07/schema' can not be resolved. Fixes microsoft#141445 * Use `@playwright/test` instead of `playwright` * Document how to unset auto reply, support null explicitly Fixes microsoft#141456 * remove unnecessary async * fix microsoft#141435 * add shell integration message to zsh part of microsoft#141448 * add shell integration message to pwsh, fix microsoft#141448 * Fix spelling error * Install playwright deps * Remove redundant 0 from bold sequence * fix microsoft#141420 * Run headless on CI * bold pwsh shell integration text * Fix cwdFolder on Windows Fixes microsoft#141443 * Move common imports to `.eslintrc.json` * Avoid `*` and spell out all allowed node modules to have squiggles when importing `vscode` by accident * Don't change target because `webpack` can't handle `es2020`. * Prevent link highlight in markdown code blocks and spans (microsoft#140816) * Prevent link highlight in markdown codeblocks (microsoft#139770) * Handle inline codespan variants for markdown link provider (microsoft#139770) * Refactor codespan detection in markdown link provider (microsoft#139770) * Add back ESM-uncomment * Remove export * fully qualify kind * Remove no longer necessary rule (microsoft#140989) * Get rid of `null!` * Fixes microsoft#140884: removal rules only target rules that appear before * handle bash login args (microsoft#141467) * support case insensitive shell executables, add tests * update with runtime key changes fixes microsoft#141389 * fixes microsoft#141387 * remove unused import * Update Codicons: Add layout icons (Refs microsoft#137633) microsoft/vscode-codicons@a2e80bf * fixes microsoft#141384 * fixes microsoft#141421 * Tweak CES survey assignment * Ambiguity in comments for createFileSystemWatcher (fix microsoft#141494) * 🆙 distro * Fix extension tree dnd supported types Fixes microsoft#141418 * Avoid `[createInstance]` warnings in unit tests * handle extension resource * Adopt `TestInstantiationService.get` * Improve comments * Improve explanations * Only log server greeting to log file, not again to the console * Avoid a lot of newlines when running from source * Fixes use of model after it got disposed. * Bump node-fetch from 2.6.1 to 2.6.7 in /extensions/github (microsoft#141538) Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.1 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.1...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * support login args on linux too * formatting and clean up * Refactors unicode highlight options * Fixes microsoft#141152 by not showing unicode highlights in the ruler or minimap. * Fix cwd setting in workspace file Fixes microsoft#136099 Co-Authored-By: Megan Rogge <merogge@microsoft.com> * update doc * fix microsoft#141366. Safari does not respect input::placeholder rules, set line height explicitly. * better warning when an extension depends on an API proposal that doesn't exist, microsoft/vscode-python#18363 * remove inlay hints config again, fixes microsoft#140225 * debug: bump js-debug * Fix microsoft#141393 * testing: add autosave before each test run * testing: add autosave before each test run Save the current project file before each test run so that the code logic is up to date when the test is run * debug: Add debug.saveBeforeTest - Fix microsoft#139125 * testing: add autosave before each test run * testing: adjust the "saveBeforeTest" to a suitable position * fix microsoft#141367. * Fix microsoft#141461 * Bump node-fetch from 2.6.1 to 2.6.7 in /extensions/github-authentication (microsoft#141537) Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.1 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.1...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump node-fetch in /extensions/microsoft-authentication (microsoft#141536) Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.1 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.1...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix microsoft#141368. Overflow. * re microsoft#141368. disable replace all if the curr match is not model. * fix microsoft#141371. * 💄 * fix microsoft#141370. Update buttons on find match state change. * update find unit test. * Move `tokenizationSupport` inside `TokenizationStateStore` (microsoft#140476) * Rearrange methods * Extract `ContiguousGrowingArray` * Improve names and documentation for `TokenizationStateStore` * Add setting to control repository scan * fix microsoft#141515. * Fix microsoft#141469 * update terminalLinkManager's processCwd when cwd changes with shell integration on (microsoft#141595) * Emit event with valid range * make terminal output readonly (microsoft#141601) * Only show link commands if a terminal has been created Fixes microsoft#141593 * Fixes microsoft#139877: Allow `DomScrollableElement` to use float scroll values * update doc * Change notebook markdown fold hint to a CellPart * Cell fold hint fixes Hide when in edit mode, simplify top calculation, fix height calc when in edit mode * compositePart should use createActionViewItem helper fixes microsoft#141399 * feedback * fix microsoft#141294 * fix Terminal: Cannot refresh property when process is undefined microsoft#141288 * Bumping eslint versions (microsoft#141121) * hBumping eslint versions - Bump eslint and typescript/eslint versions to latest - Fixing `code-no-unused-expression` for `x?.(b);` type statements - Fixed a few new semicolon errors from upgrade * Bump eslint parser in build * Fix eslint errors in d.ts * update layout state prefix fixes microsoft#141372 microsoft#141376 microsoft#141374 * Fix import path * Close microsoft#141465 * fixes microsoft#141398 * fixes microsoft#141404 * unused import * Add link to sort description * Close microsoft#141555 * refs microsoft#141426 * fixes microsoft#141432 * fixes microsoft#141552 * Instrument watermark opening * Adding video tutorials to get started * add customize layout icons refs microsoft#137633 * Remove stale comment microsoft#140878 is fixed * Startup dialog goes through the request service (microsoft#141592) * show error when inlay hints command fails, annotate error with source (e.g extension name), fixes microsoft#141588 * Fixes microsoft#138746. * - Check if URL is pointing to the right service - Set selective request and response headers - Update the scheme on the client * cache resourceUrlTemplate Uri * Fixes microsoft#69391: Reserve extra bottom padding when the hover has a horizontal scrollbar * fix microsoft#141643 * Revert "always set aria-selected, even for listbox" This reverts commit 1356392. * Fixes microsoft#141638: `-command` rules should only remove default rules * fix microsoft#141299 * Remove terminalLocation from api proposal list Fixes microsoft#141645 * Match z-index on parameter hints to the hover Fixes microsoft#140761 * Reveal panel/editor when running a recent command/dir Fixes microsoft#141619 * Ensure quick pick is closed on view output Fixes microsoft#141615 * Inconsistent single quotes use in --help (same for code --help) * Reduce duplication * Fixes microsoft#25221: Render line highlights for all cursors * server: port range is end inclusive, improve validation * fix typo * Use `display:none` when overview ruler is turned off * Better align simple options with `<input>`s * Fixes microsoft#140367: Take into account horizontal padding when layouting the editor * Update scripts to point to `tsc` one folder up * Fix microsoft#141331 * Update description (microsoft/vscode-remote-release#6184) * fix typos * fix microsoft#141633 * await open editor * Allow richer commands in get started entries * Update src/vs/workbench/contrib/terminal/browser/terminalInstance.ts Co-authored-by: Megan Rogge <megan.rogge@microsoft.com> * create process in an empty workspace when cwd is userHome (microsoft#141660) * Fixes microsoft#140490 by always using `cursor:text` on macOS instead of our custom cursor. Since macOS Catalina the native cursor has a white border which makes it work well on dark themes, making our custom cursor not necessary. Also, macOS High Sierra is no longer officially supported by Apple (ref microsoft#96946) * Update shell integration config description Fixes microsoft#141308 * --help should read better * tty for ./scipts/code-server * Support null in auto replies setting Fixes microsoft#141666 * Improve auto replies config more Part of microsoft#141666 * debug: bump js-debug * Update typescript-eslint/experimental-utils Fixes microsoft#141653 * Update Codicons: Add modes and menu bar microsoft/vscode-codicons@ee85be1 * tweak setting language * refs microsoft#137633 * testing: fix inline decoration overlap Fixes microsoft#138915 * Use fully qualified names in @link * Fix `undefined`s in text search results (microsoft#141522) * Revert "create process in an empty workspace when cwd is userHome (microsoft#141660)" This reverts commit a58b538. * copy & continue. Fixes microsoft/vscode-internalbacklog#2613 * fixes microsoft#141471 * Fix microsoft#141477 * readonly * type -> interface * Avoid lookbehind in regexp Fixes microsoft#141689 * Clean up unused method, re microsoft#139541 * 💄 re microsoft#141582 * fix microsoft#141686 * Disable windows adjustment for active indicator (Refs microsoft#140647) * Temporary window shift * Revert * Dont require steps to be defined Fixes microsoft#141603 * Fix microsoft#141434 * Fix microsoft#141439 * microsoft#141054 enable the tests and keep debugging * Revert "fix microsoft#141686" This reverts commit 4af3e14 Didn't seem to fix the issue * Bump distro * Revert "support file llink" This reverts commit 09108ba. * Trim characters off match instead to get key, fixes microsoft#141614 (microsoft#141818) * Fix microsoft#141910 * Revert "fix microsoft#140907" This reverts commit a81c3b0. * Ensure parameter hints z-index is lower than suggest Terminal screen element's z-index is 31 Fixes microsoft#141947 * Fix comments can't be updated (microsoft#142013) Fixes of microsoft#142012 * debug: fix action bar input being hidden (microsoft#142230) For microsoft#142010 * Revert "debug: fix action bar input being hidden (microsoft#142230)" (microsoft#142240) This reverts commit 4a4c17c. * Bump distro and version (microsoft#142419) * Disable auto replies by default Fixes microsoft#142341 * Latest update breaks due to proxy requirement. Fixes microsoft#142201 * debug: bump js-debug (microsoft#142531) * debug: fix action bar input being hidden (microsoft#142530) For microsoft#142010 * GVFS: can't open file (fix microsoft#142481) (microsoft#142499) * safeguard init exthost message (microsoft#142486) * Execution object should be able to be returned by getCellExecution at the time the change event is fired microsoft#142466 * Make sure we pass along windows style paths to pluginProbeLocations (microsoft#142420) * Fix bare math blocks with nested beging/end (microsoft#142136) Fixes microsoft#141905 This picks up microsoft/vscode-markdown-it-katex@b1ed14d * Fix quoting for tasks (microsoft#142400) Fixes microsoft#142196 * Bump version to 1.64.2 * refs microsoft#142176 (microsoft#142423) * Candidate/142146 (microsoft#142424) * refs microsoft#142146 * refs microsoft#142146 * Fix microsoft#142421 (microsoft#142433) POINTER_DOWN was stealing too many events. The old event handlers handled events such as MOUSE_UP, and it turns out we can just use POINTER_UP instead. * fixes microsoft#141349 (microsoft#142644) * fixes microsoft#141349 * additional handling of the panel position with panel alignment * chore: update package.json and yarn.lock From what I can tell, it looks like there aren't many changes here. cookie was added as a devDependency. We had that as a regular dependency already. I moved it to match theirs. They were also using 0.4.0 while we had 0.4.1. Hope that doesn't matter. The other big update was eslint to 8.7.0 from 6.8.0. That could cause breaking changes potentially. Something to look out for. * feat: update product.json I don't see anything changed here for us to worry about. This is mostly making sure we keep the right names on win32. * fix: dont use remote node in code-server.sh I am unsure if this was the right move but it appears that we commented this out previously and did not load remote node. I think this is because it leads to Node version discrepencies which we don't want. * feat: add getPreferredWebSchema network.ts It appears they added a new method to the RemoteAuthoritiesImpl called `getPreferredWebSchema` which returns either 'http' or 'https'. * chore: resolve conflicts in src/vs/code/browser/workbench/workbench-dev.html Not much to report here. Seems like nothing new. * chore: update src/vs/code/browser/workbench/workbench.html Based on what I can tell, they changed workbench.web.api to workbench.web.main for most of these static assets. I hope that is accurate. * fix: conflict in src/vs/platform/remote/browser/browserSocketFactory.ts I am not 100% if the new code is similar to ours. We had to patch this to work against the current path. Their new implementation may do the same thing but I couldn't tell from looking at it. We may want to revisit this later when we switch to patches. Hopefully we can remove this. * fix: src/vs/platform/remote/common/remoteAgentConnection.ts It appears they've added a new parameter to `createSocket` which takes a string for a debugLabel. Not sure how it's used or made available but it's interesting because it takes the `connectionTypeToString` which we're adding to the query. Makes me think we might be able to remove this patch if our backend can get access to the debugLabel somehow. * fix: src/vs/server/node/serverEnvironmentService.ts Seems like a bunch of new serverOptions were added, some deprecated. I am not sure how this will affect code-server. They added 'host' so I wonder if we could deprecate 'bind-address' on the code-server side and instead use host:port with VS Code. Something to consider. * fix: src/vs/workbench/browser/web.main.ts Nothing major here. Had to add a random property called `ctor` to the CodeServerAdditions class. Also used connectionTokenCookie instead of hard-coded string which is a nice addition. * fix: src/vs/workbench/browser/web.api.ts Clean up IWorkbenchConstructionOptions. That's mostly it here. * fix: src/vs/workbench/contrib/extensions/browser/extensionsViewlet.ts Added flexible:Height: true to the SyncDescriptor since we were missing it. Removed a block that showed the prevented the web view extensions from automatically hiding. I did this because upstream removed two properties it was using: this.hasInstalledWebExtensionsContextKey and this.updateInstalledWebExtensionsContext. I hope that was right. * fix: src/vs/server/node/server.main.ts I removed `args['server-data-dir']` from `REMOTE_DATA_FOLDER` since we don't have access to `args` here. The other change was the `{ mode: 0o700 }` added to the `fs.mkdirSync` call. Not sure if that's related to chmod 0700 or something else. * wip * fix: conflicts in src/vs/server/node/webClientServer.ts We resolved a few things here with the conflicts. * fix: src/vs/code/browser/workbench/workbench.ts We were able to remove a couple of our patches, which is awesome! Still have some things to test though. * fix: src/vs/server/node/remoteExtensionHostAgentServer.ts Moved our custom serverThemeService into the src/vs/server/node folder and added the missing _serviceBrand to the interface and the class to fix a ctor error. * fix: remove clientTheme from webClientServer * fix: also remove from html files * fix: add missing __metadata change * chore: clean up code comments * chore: clean up comments * chore: fix typo * wip: add notes for debugging folder query param * refactor: remove workspace & folder from code-server args * fixup!: clean up TODOS * revert(code-server.sh): match upstream Co-authored-by: Connor Peet <connor@peet.io> Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com> Co-authored-by: Alex Ross <alros@microsoft.com> Co-authored-by: Joao Moreno <joao.moreno@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alex Dima <alexdima@microsoft.com> Co-authored-by: Logan Ramos <lramos15@gmail.com> Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Co-authored-by: Martin Aeschlimann <martinae@microsoft.com> Co-authored-by: meganrogge <merogge@microsoft.com> Co-authored-by: Waqas Ali <waqas.abbasi@outlook.com> Co-authored-by: Matt Bierner <matb@microsoft.com> Co-authored-by: Tyler Leonhardt <me@tylerleonhardt.com> Co-authored-by: Megan Rogge <megan.rogge@microsoft.com> Co-authored-by: SteVen Batten <sbatten@microsoft.com> Co-authored-by: Miguel Solorio <miguel.solorio@microsoft.com> Co-authored-by: Harald Kirschner <hkirschner@microsoft.com> Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com> Co-authored-by: rebornix <penn.lv@gmail.com> Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com> Co-authored-by: Hans <416870376@qq.com> Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> Co-authored-by: Jackson Kearl <jakearl@microsoft.com> Co-authored-by: Rob Lourens <roblourens@gmail.com> Co-authored-by: isidor <inikolic@microsoft.com> Co-authored-by: Christof Marti <chrmarti@microsoft.com> Co-authored-by: gregvanl <gregvanl@microsoft.com> Co-authored-by: Benjamin Tidor <benjamin@tidor.net> Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com> Co-authored-by: Henning Dieterichs <notify.henning.dieterichs@live.de> Co-authored-by: SteVen Batten <6561887+sbatten@users.noreply.github.com>

noahehall changed the title ~~How can we move the temrinal panel to the right?~~ How can we move the termin panel to the right? Jan 25, 2022

noahehall changed the title ~~How can we move the termin panel to the right?~~ How can we move the terminal panel to the right? Jan 25, 2022

vscode-triage-bot assigned paulacamargo25 Jan 25, 2022

sbatten removed the triage-needed label Jan 25, 2022

sbatten assigned sbatten and unassigned paulacamargo25 Jan 25, 2022

sbatten added feature-request Request for new features or functionality layout General VS Code workbench layout issues labels Jan 25, 2022

sbatten mentioned this issue Feb 4, 2022

Please bring back ability to move terminal to the RIGHT of the editor #142075

Closed

sbatten changed the title ~~How can we move the terminal panel to the right?~~ How can we move the new side panel to the right? Feb 4, 2022

gjsjohnmurray mentioned this issue Feb 4, 2022

Side Bar and Side Panel can not be moved to right side together #142179

Closed

gjsjohnmurray mentioned this issue Feb 4, 2022

Terminal side panel can no longer be moved to the left, next to explorer #142181

Closed

kklot mentioned this issue Feb 10, 2022

support moving the new side panel iocave/customize-ui#123

Open

heartacker mentioned this issue Feb 10, 2022

how can we lay side-bar and side panel at the same side #142742

Closed

nguyendviet mentioned this issue Feb 10, 2022

Allow to minimize Side Panel #142579

Closed

IllusionMH mentioned this issue Feb 11, 2022

Allow moving the side-panel next to the explorer panel #142819

Closed

carlfriedrich mentioned this issue Feb 11, 2022

Make the "Side Panel" more flexible and rename it accordingly #142832

Closed

sbatten mentioned this issue Feb 22, 2022

Side panel can't be hidden using a shortcut #143571

Closed

github-actions bot locked and limited conversation to collaborators Mar 27, 2022

How can we move the new side panel to the right? #141349

How can we move the new side panel to the right? #141349

Comments

noahehall commented Jan 25, 2022 • edited

gjsjohnmurray commented Jan 25, 2022

sbatten commented Jan 25, 2022

hello-smile6 commented Feb 4, 2022

ArturoDent commented Feb 4, 2022

gotofritz commented Feb 4, 2022 • edited

gjsjohnmurray commented Feb 4, 2022

gjsjohnmurray commented Feb 4, 2022

gotofritz commented Feb 4, 2022 • edited

gotofritz commented Feb 4, 2022

gjsjohnmurray commented Feb 4, 2022

adam-arold commented Feb 4, 2022

adam-arold commented Feb 4, 2022

avianion commented Feb 4, 2022

gjsjohnmurray commented Feb 4, 2022

carlfriedrich commented Feb 4, 2022 • edited

General thoughts

Missed opportunities

The workaround

Proposed steps

The bottom line

adam-arold commented Feb 4, 2022 • edited

adam-arold commented Feb 4, 2022 • edited

adam-arold commented Feb 4, 2022

martin-braun commented Feb 10, 2022 • edited

adam-arold commented Feb 10, 2022

ArturoDent commented Feb 10, 2022

martin-braun commented Feb 11, 2022 • edited

h3d0 commented Feb 11, 2022 • edited

gjsjohnmurray commented Feb 11, 2022

h3d0 commented Feb 11, 2022 • edited

martin-braun commented Feb 11, 2022 • edited

adam-arold commented Feb 12, 2022 • edited

carlfriedrich commented Feb 14, 2022 • edited

jsbrain commented Feb 14, 2022

clytras commented Feb 14, 2022

gotofritz commented Feb 14, 2022

heartacker commented Feb 14, 2022

adam-arold commented Feb 14, 2022

dewetblomerus commented Feb 15, 2022

fdiasr commented Feb 15, 2022

adam-arold commented Feb 16, 2022

liborty commented Feb 23, 2022 • edited

martin-braun commented Feb 23, 2022 • edited

dewetblomerus commented Feb 23, 2022

liborty commented Feb 24, 2022 • edited

noahehall commented Jan 25, 2022 •

edited

gotofritz commented Feb 4, 2022 •

edited

gotofritz commented Feb 4, 2022 •

edited

carlfriedrich commented Feb 4, 2022 •

edited

adam-arold commented Feb 4, 2022 •

edited

adam-arold commented Feb 4, 2022 •

edited

martin-braun commented Feb 10, 2022 •

edited

martin-braun commented Feb 11, 2022 •

edited

h3d0 commented Feb 11, 2022 •

edited

h3d0 commented Feb 11, 2022 •

edited

martin-braun commented Feb 11, 2022 •

edited

adam-arold commented Feb 12, 2022 •

edited

carlfriedrich commented Feb 14, 2022 •

edited

liborty commented Feb 23, 2022 •

edited

martin-braun commented Feb 23, 2022 •

edited

liborty commented Feb 24, 2022 •

edited