Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no confirmation window while drag-dropping project files in the "Explore" panel. #1414

Closed
Egorrr opened this issue Dec 17, 2015 · 15 comments
Assignees
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues on-testplan
Milestone

Comments

@Egorrr
Copy link

Egorrr commented Dec 17, 2015

Without confirmation window on drag-dropping files in the Explore panel there is a chance to accidentally move project files to another directory.

@dbaeumer dbaeumer added the feature-request Request for new features or functionality label Dec 17, 2015
@dbaeumer dbaeumer added this to the Backlog milestone Dec 17, 2015
@dbaeumer
Copy link
Member

@bpasero IMO not asking for confirmation is what I expect. Normal OS explorers behave the same. However they allow me to undo such changes. So I would expect undo in VSCode as well.

@bpasero
Copy link
Member

bpasero commented Dec 17, 2015

👍

@bpasero bpasero added file-explorer Explorer widget issues and removed workbench labels Dec 18, 2015
@Egorrr
Copy link
Author

Egorrr commented Dec 21, 2015

I'm not sure is its correct comparison, but for example in Jetbrains Webstorm when I drag-drop files there I see a confirmation window, which protects from accidentally moving some files from one directory to another. Otherwise, you can somehow drag files with your mouse and not even notice that.

@Matthijs-Wessels
Copy link

I have had this problem many times and even had a plugin in Visual Studio .NET that did this for me: Here's a user-voice post for this same feature: https://visualstudio.uservoice.com/forums/293070-visual-studio-code/suggestions/11312763-ask-before-moving-files-in-solution-explorer-tree

@bpasero bpasero self-assigned this Mar 30, 2016
@gaguirre
Copy link

Hi @dbaeumer, I think could be (and perhaps should be) different features:

  • Showing a confirmation window (with do not ask me anymore option maybe)
  • Undo changes in the Explore panel

Recently I had to look at "git status" and figure out which file I moved accidentally, and it's really a pain.

@jamietre
Copy link

+1, I just did this and had a Visual Studio PTSD response.

@bpasero
Copy link
Member

bpasero commented Jul 5, 2016

Fyi for July (or insiders) #4842 is pushed and allows to disable DND in the explorer.

@bpasero bpasero removed their assignment Aug 17, 2016
@bpasero bpasero added the help wanted Issues identified as good community contribution opportunities label May 11, 2017
@bpasero
Copy link
Member

bpasero commented May 11, 2017

PR welcome.

@snhardin
Copy link

Hi! I'd like to work on this. This is something that's annoyed me for a while now.

@patwaswapnil
Copy link

Its very annoying when a folder goes (i dont even know where and what) by accident. Especially when using touchpad.

The worst thing is when working on others directory and dont know the actual structure.

@a-eid
Copy link

a-eid commented Aug 22, 2017

+1
there should be either a confirmation dialog or an undo functionality

@andypotts
Copy link

+1

@BrennerSpear
Copy link

+1

Is there anything like cmd+Z for this?

@jfconde
Copy link

jfconde commented Sep 15, 2017

+1. It's specially painful to move node_modules, or accidentally moving your mouse and not even having an idea of what has been moved to where.

@bpasero bpasero added this to the October 2017 milestone Oct 6, 2017
@bpasero bpasero self-assigned this Oct 6, 2017
@bpasero bpasero removed the help wanted Issues identified as good community contribution opportunities label Oct 6, 2017
@bpasero bpasero closed this as completed in a42f794 Oct 6, 2017
@bpasero
Copy link
Member

bpasero commented Oct 6, 2017

I added a new setting "explorer.confirmDragAndDrop": true which is enabled by default and shows a confirm dialog that provides a checkbox to quickly change this setting to no longer show a confirmation:

image

sandy081 pushed a commit that referenced this issue Oct 16, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.