Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cell range off-by-one #141687

Closed
roblourens opened this issue Jan 28, 2022 · 1 comment
Closed

Cell range off-by-one #141687

roblourens opened this issue Jan 28, 2022 · 1 comment
Assignees
@roblourens @rebornix
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Milestone
February 2022

Comments

@roblourens
Copy link
Member

ICellRange returned by INotebookEditor#visibleRanges are inclusive - a notebook with one cell gives { start: 0, end: 0 }. The cell ranges that getCellsInRange takes are exclusive, and that range is considered empty. See #141477
@roblourens roblourens added this to the February 2022 milestone Jan 28, 2022
@roblourens
Copy link
Member Author

The range comes from here:

vscode/src/vs/workbench/contrib/notebook/browser/view/notebookCellList.ts

Line 263 in 6188148

this.visibleRanges = [{ start: topModelIndex, end: bottomModelIndex }];

@rebornix rebornix added the debt Code quality issues label Feb 4, 2022
roblourens added a commit that referenced this issue Feb 4, 2022
@roblourens
Adapt cell ranges for #141687
5004a07
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@rebornix rebornix

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
February 2022
Development

No branches or pull requests
3 participants
@roblourens @rebornix and others