Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify IShellLaunchConfig.description #141899

Closed
Tyriar opened this issue Jan 31, 2022 · 0 comments · Fixed by #141913
Closed

Simplify IShellLaunchConfig.description #141899

Tyriar opened this issue Jan 31, 2022 · 0 comments · Fixed by #141913
Assignees
@Tyriar @meganrogge
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal-tabs
Milestone
February 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 31, 2022

After a quick review I think we can change this property to be more correct as the following:

/**
 * A string to follow the name of the terminal with, indicating a special kind of terminal
 */
type?: 'local' | 'task'

Need to verify related features in panel/editor terminals.
@Tyriar Tyriar added debt Code quality issues terminal-tabs labels Jan 31, 2022
@Tyriar Tyriar added this to the February 2022 milestone Jan 31, 2022
meganrogge added a commit that referenced this issue Feb 1, 2022
@meganrogge
Fix #141899
144d636
@meganrogge meganrogge mentioned this issue Feb 1, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal-tabs
Projects
None yet
Milestone
February 2022
Development

Successfully merging a pull request may close this issue.

SLC description -> type microsoft/vscode
3 participants
@Tyriar @meganrogge and others