Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking in cell output does not focus the cell #142239

Closed
roblourens opened this issue Feb 4, 2022 · 3 comments · Fixed by #148978
Closed

Clicking in cell output does not focus the cell #142239

roblourens opened this issue Feb 4, 2022 · 3 comments · Fixed by #148978
Assignees
@roblourens @rebornix
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-output verified Verification succeeded
Milestone
May 2022

Comments

@roblourens
Copy link
Member

  • Execute a cell with a webview output
  • Click in the output on an element that is not focusable
  • The cell is not focused (focus bar on the side is not blue). If it had focus, it loses focus
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug notebook-output labels Feb 4, 2022
@roblourens roblourens added this to the February 2022 milestone Feb 4, 2022
@roblourens roblourens self-assigned this Feb 4, 2022
@rebornix
Copy link
Member

rebornix commented Feb 5, 2022

@roblourens good catch. the focus tracker is out of date and doesn't really work with current DOM structure/

@roblourens
Copy link
Member Author

Oops I was just fixing this haha

@roblourens
Copy link
Member Author

This change will set outputIsFocused to true, then it will never go back to false. I was just going to set the tabIndex on the output element, so the 'focus' listener on it would work. What do you think about that? Dunno how this worked before

roblourens added a commit that referenced this issue Feb 18, 2022
@roblourens
Revert "fix #142239."
821cd16 
This reverts commit f71d4b6.
roblourens added a commit that referenced this issue Feb 18, 2022
@roblourens
Set tabindex on output container so focus/blur listeners will fire
82a65e1 
Fix #142239
@roblourens roblourens reopened this Feb 22, 2022
@roblourens roblourens modified the milestones: February 2022, March 2022 Feb 22, 2022
@roblourens roblourens modified the milestones: March 2022, April 2022 Mar 23, 2022
@roblourens roblourens modified the milestones: April 2022, May 2022 Apr 22, 2022
rebornix added a commit that referenced this issue May 7, 2022
@rebornix
fix #142239.
ebae173
@rebornix rebornix mentioned this issue May 7, 2022
Merged
@joyceerhl joyceerhl added the verified Verification succeeded label Jun 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-output verified Verification succeeded
Projects
None yet
Milestone
May 2022
Development

Successfully merging a pull request may close this issue.

Prevent earger list container and webview re-focus microsoft/vscode
5 participants
@roblourens @rebornix @greazer @joyceerhl and others