New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed settings sync has duplicate logins #142340
Conversation
Code looks good! Can you share a picture of what the end result looks like in the Account menu (in the bottom left) |
@TylerLeonhardt here is the ss. |
That's coming from the wrong window. You need to build and run VS Code out of sources for me to accept this PR. Here are steps: https://github.com/microsoft/vscode/wiki/How-to-Contribute Also remember what I said about Testing in the issue:
|
@TylerLeonhardt I am getting the following error.
|
can you try running:
|
@TylerLeonhardt this is how it looks when I build and run VS Code out of sources |
@Yash621 awesome! You got it! So I think the parens and then parens are not great... could we do:
instead? |
@TylerLeonhardt I have updated the text style. |
I like it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM awesome work!
@TylerLeonhardt thanks :) |
@TylerLeonhardt btw why didn't got merged ? |
I just wanted to check one more thing. Looks good |
@TylerLeonhardt thanks :) |
This PR is with respect to issue #139323
@TylerLeonhardt I have implemented all the suggested changes ,
please review them and let me know if any more changes are required.