Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed settings sync has duplicate logins #142340

Merged
merged 4 commits into from Feb 8, 2022
Merged

Conversation

Yash621
Copy link
Contributor

@Yash621 Yash621 commented Feb 6, 2022

This PR is with respect to issue #139323

@TylerLeonhardt I have implemented all the suggested changes ,
please review them and let me know if any more changes are required.

@TylerLeonhardt
Copy link
Member

Code looks good! Can you share a picture of what the end result looks like in the Account menu (in the bottom left)

@TylerLeonhardt TylerLeonhardt added the authentication Issues with the Authentication platform label Feb 6, 2022
@TylerLeonhardt TylerLeonhardt added this to the February 2022 milestone Feb 6, 2022
@Yash621
Copy link
Contributor Author

Yash621 commented Feb 7, 2022

@TylerLeonhardt here is the ss.
Screenshot_2022-02-07_17-37-36 (1)

@TylerLeonhardt
Copy link
Member

That's coming from the wrong window. You need to build and run VS Code out of sources for me to accept this PR. Here are steps:

https://github.com/microsoft/vscode/wiki/How-to-Contribute

Also remember what I said about Testing in the issue:

Testing

Testing this change is a little tricky because nothing inbox in the OSS version of vscode uses the Microsoft auth stuff, but what you can do is download my Microsoft To Do extension (using the "Download extension" button on the right side) and then install it in Code OSS using "Install from VSIX"

@Yash621
Copy link
Contributor Author

Yash621 commented Feb 7, 2022

@TylerLeonhardt I am getting the following error.
when I run ./scripts/code.sh

  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/home/yash/vscode/out/vs/code/electron-main/main.js',
  phase: 'loading',
  moduleId: 'vs/code/electron-main/main',
  neededBy: [ '===anonymous1===' ]
}
[3464:0207/233148.803814:ERROR:sandbox_linux.cc(374)] InitializeSandbox() called with multiple threads in process gpu-process.```


@TylerLeonhardt
Copy link
Member

can you try running:

> yarn
> yarn run compile
> ./scripts/code.sh

@Yash621
Copy link
Contributor Author

Yash621 commented Feb 8, 2022

@TylerLeonhardt this is how it looks when I build and run VS Code out of sources
please review it and let me know if any changes are required :

Screenshot_2022-02-09_00-00-18 (1)

@TylerLeonhardt
Copy link
Member

@Yash621 awesome! You got it! So I think the parens and then parens are not great... could we do:

Yash Goel - yg17381@gmail.com (Microsoft)

instead?

@Yash621
Copy link
Contributor Author

Yash621 commented Feb 8, 2022

@TylerLeonhardt I have updated the text style.

Screenshot_2022-02-09_00-24-31 (1)

@TylerLeonhardt
Copy link
Member

I like it!

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM awesome work!

@Yash621
Copy link
Contributor Author

Yash621 commented Feb 8, 2022

@TylerLeonhardt thanks :)

@Yash621
Copy link
Contributor Author

Yash621 commented Feb 8, 2022

@TylerLeonhardt btw why didn't got merged ?

@TylerLeonhardt
Copy link
Member

I just wanted to check one more thing. Looks good

@TylerLeonhardt TylerLeonhardt merged commit 5ea92ff into microsoft:main Feb 8, 2022
@Yash621
Copy link
Contributor Author

Yash621 commented Feb 8, 2022

@TylerLeonhardt thanks :)

@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
authentication Issues with the Authentication platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants