Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make inlay hints accessible #142532

Closed
jrieken opened this issue Feb 8, 2022 · 2 comments
Closed

Make inlay hints accessible #142532

jrieken opened this issue Feb 8, 2022 · 2 comments
Assignees
@jrieken
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality inlay-hints on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Milestone
February 2022

Comments

@jrieken
Copy link
Member

jrieken commented Feb 8, 2022

Inlay hints are currently not accessible and should define model for that
@jrieken jrieken self-assigned this Feb 8, 2022
@jrieken jrieken added feature-request Request for new features or functionality inlay-hints labels Feb 8, 2022
@jrieken jrieken modified the milestones: Backlog, February 2022 Feb 8, 2022
@jrieken jrieken added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Feb 9, 2022
jrieken added a commit that referenced this issue Feb 11, 2022
@jrieken
add command and logic to start/stop reading the current line with inl…
6e5373e 
…ay hints, #142532
@jrieken
Copy link
Member Author

jrieken commented Feb 11, 2022

First version is done: there is start/stop read line with hints commands

Screen Shot 2022-02-11 at 11 15 47

jrieken added a commit that referenced this issue Feb 21, 2022
@jrieken
cap line length when reading inlay hints, #142532
d0ec101
@jrieken
Copy link
Member Author

jrieken commented Feb 21, 2022 •
edited
Loading

To verify

  • enable screen reading
  • select F1 > Read Line with Inlay Hint
  • ensure the line is read with its inlay hints
  • ensure ESC brings you back to the editor
  • ensure a cue is playing when invoking the command on a line w/o hints

@jrieken jrieken added the verification-needed Verification of issue is requested label Feb 21, 2022
@jrieken jrieken closed this as completed Feb 21, 2022
@jrieken jrieken mentioned this issue Feb 21, 2022
Merged
@rzhao271 rzhao271 added the verified Verification succeeded label Feb 23, 2022
@jrieken jrieken added the on-release-notes Issue/pull request mentioned in release notes label Feb 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality inlay-hints on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
February 2022
Development

No branches or pull requests
2 participants
@jrieken @rzhao271