Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle skipped commands in bash/zsh #142640

Closed
Tyriar opened this issue Feb 9, 2022 · 1 comment
Closed

Handle skipped commands in bash/zsh #142640

Tyriar opened this issue Feb 9, 2022 · 1 comment
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Milestone
February 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 9, 2022

pwsh support was just pushed such that we can identify when a shell is just returning a new prompt like run running the empty string or hitting ctrl+c. We should bring this to bash/zsh
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration, command decorations, etc. labels Feb 9, 2022
@Tyriar Tyriar added this to the February 2022 milestone Feb 9, 2022
@Tyriar Tyriar assigned Tyriar and meganrogge and unassigned meganrogge Feb 9, 2022
Tyriar added a commit that referenced this issue Feb 14, 2022
@Tyriar
Handle skipped commands in bash
6e63b1e 
Part of #142640
@Tyriar
Copy link
Member Author

Tyriar commented Feb 18, 2022

Works for bash, not zsh yet

@Tyriar Tyriar changed the title Handle empty/canceled commands in bash/zsh Handle skipped commands in bash/zsh Feb 18, 2022
@Tyriar Tyriar closed this as completed in 5130d2e Feb 18, 2022
@connor4312 connor4312 added the verified Verification succeeded label Feb 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
February 2022
Development

No branches or pull requests
4 participants
@Tyriar @connor4312 @meganrogge and others