Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find - Replace all option in Jupyter Notebook has become non-actionable #142756

Closed
rohan-paul opened this issue Feb 10, 2022 · 8 comments · Fixed by #148725
Closed

Find - Replace all option in Jupyter Notebook has become non-actionable #142756

rohan-paul opened this issue Feb 10, 2022 · 8 comments · Fixed by #148725
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-find verified Verification succeeded
Milestone
May 2022

Comments

@rohan-paul
Copy link

image

  • VS Code Version:
    Version: 1.64.1
    Commit: d6ee99e
    Date: 2022-02-07T17:17:47.733Z
    Electron: 13.5.2
    Chromium: 91.0.4472.164
    Node.js: 14.16.0
    V8: 9.1.269.39-electron.0
    OS: Linux x64 5.13.0-28-generic

  • OS Version: Ubuntu 20.04

Steps to Reproduce:

  1. In a Jupyter notebook, just do Ctrl+H and put some strings in find and replace boxes.
@rohan-paul
Copy link
Author

Hi @rebornix - Apology to bother. Is there any update on this issue or any work-around that I can do.

Because without the replace-all functionality, it's becoming very hard to manage long notebooks in VSCode.

@greazer greazer added bug Issue identified by VS Code Team member as probable bug nb-golden and removed notebook-triage labels Mar 7, 2022
@roblourens roblourens self-assigned this Mar 23, 2022
@roblourens roblourens added this to the April 2022 milestone Mar 23, 2022
@rebornix rebornix modified the milestones: April 2022, March 2022 Mar 28, 2022
@rebornix rebornix added the candidate Issue identified as probable candidate for fixing in the next release label Mar 28, 2022
@rebornix
Copy link
Member

Just realized this is a regression from previously stable.

rebornix added a commit that referenced this issue Mar 28, 2022
@rebornix
fix #142756.
3dc701c
@rebornix rebornix mentioned this issue Mar 28, 2022
Merged
rebornix added a commit that referenced this issue Mar 28, 2022
@rebornix
Merge pull request #146213 from microsoft/rebornix/update-replace-all-nb
3a5a169 
fix #142756 update replace all button after input is updated
@rohan-paul
Copy link
Author

rohan-paul commented Mar 29, 2022 •
edited

NOT Resolved in the latest stable version of code.

Version: 1.65.2
Commit: c722ca6c7eed3d7987c0d5c3df5c45f6b15e77d1
Date: 2022-03-10T15:36:26.048Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Linux x64 5.13.0-39-generic

@rzhao271
Copy link
Contributor

Not working on the latest Insiders

Version: 1.66.0-insider (user setup)
Commit: 521a3d8
Date: 2022-03-29T07:31:54.286Z
Electron: 17.2.0
Chromium: 98.0.4758.109
Node.js: 16.13.0
V8: 9.8.177.11-electron.0
OS: Windows_NT x64 10.0.19043

@rzhao271 rzhao271 reopened this Mar 30, 2022
@rzhao271 rzhao271 added the verification-found Issue verification failed label Mar 30, 2022
LcJuves pushed a commit to LcJuves/vscode that referenced this issue Mar 31, 2022
@rebornix
fix microsoft#142756.
ca1a874
LcJuves pushed a commit to LcJuves/vscode that referenced this issue Mar 31, 2022
@rebornix
Merge pull request microsoft#146213 from microsoft/rebornix/update-re…
f381db0 
…place-all-nb

fix microsoft#142756 update replace all button after input is updated
@rohan-paul
Copy link
Author

After updating to version 1.66.0 - I get the "Replace All" button activated (as in not grayed-out any more) - But it does NOT work. i.e. after clicking on the button naothing happens.

Version: 1.66.0
Commit: e18005f0f1b33c29e81d732535d8c0e47cafb0b5
Date: 2022-03-30T05:50:41.156Z
Electron: 17.2.0
Chromium: 98.0.4758.109
Node.js: 16.13.0
V8: 9.8.177.11-electron.0
OS: Linux x64 5.13.0-39-generic

@roblourens roblourens removed their assignment Apr 22, 2022
@rzhao271 rzhao271 removed the candidate Issue identified as probable candidate for fixing in the next release label Apr 28, 2022
@rebornix rebornix removed this from the April 2022 milestone Apr 28, 2022
@rebornix rebornix added this to the May 2022 milestone Apr 28, 2022
rebornix added a commit that referenced this issue May 4, 2022
@rebornix
Fix #142756.
5b36159
@rebornix rebornix mentioned this issue May 4, 2022
Merged
@rebornix rebornix removed the verification-found Issue verification failed label May 4, 2022
rebornix added a commit that referenced this issue May 4, 2022
@rebornix
Fix #142756. (#148725)
40524ee
@rohan-paul
Copy link
Author

Hi, this is still not resolved after today's release to Version: 1.67.1

Below my current version details.

Version: 1.67.1
Commit: da15b6fd3ef856477bf6f4fb29ba1b7af717770d
Date: 2022-05-06T12:39:22.915Z
Electron: 17.4.1
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Linux x64 5.13.0-41-generic

@rzhao271
Copy link
Contributor

@rohan-paul can you try again on VS Code Insiders?
Otherwise, you'll have to wait for version 1.68.

@rohan-paul
Copy link
Author

@rohan-paul can you try again on VS Code Insiders? Otherwise, you'll have to wait for version 1.68.

Great its working in the Insider version. Thanks.

@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Jun 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-find verified Verification succeeded
Projects
None yet
Milestone
May 2022
Development

Successfully merging a pull request may close this issue.

Fix #142756 microsoft/vscode
7 participants
@roblourens @rebornix @TylerLeonhardt @rzhao271 @greazer @rohan-paul and others