Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown path IntelliSense should escapse URLs #142838

Closed
laggingreflex opened this issue Feb 11, 2022 · 1 comment
Closed

Markdown path IntelliSense should escapse URLs #142838

laggingreflex opened this issue Feb 11, 2022 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues verified Verification succeeded
Milestone

Comments

@laggingreflex
Copy link

laggingreflex commented Feb 11, 2022

Steps to Reproduce:

  1. Use Markdown path IntelliSense
  2. Select a path that has space in it, e.g.: "../Other File.md"

Expected:

It should insert "../Other%20File":

[Other File](../Other%20File.md)

Actual:

It inserts "../Other File.md" with the space which breaks the link:

[Other File](../Other File.md)

Version: 1.64.1

@mjbvz mjbvz added this to the February 2022 milestone Feb 11, 2022
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues labels Feb 11, 2022
@mjbvz mjbvz closed this as completed in 7f5be63 Feb 12, 2022
@lramos15 lramos15 added the verified Verification succeeded label Feb 24, 2022
@lramos15
Copy link
Member

@mjbvz While this works now is there anyway to have the make it so the text in the completion widget still has the space while the inserted link has the escaped characters?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders markdown Markdown support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@laggingreflex @lramos15 @mjbvz and others