Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decorations should be hidden when the alt buffer is active #142859

Closed
meganrogge opened this issue Feb 11, 2022 · 2 comments
Closed

Decorations should be hidden when the alt buffer is active #142859

meganrogge opened this issue Feb 11, 2022 · 2 comments
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Milestone
February 2022

Comments

@meganrogge
Copy link
Contributor

Screen Shot 2022-02-11 at 10 48 00 AM
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal-command-decoration labels Feb 11, 2022
@meganrogge meganrogge added this to the February 2022 milestone Feb 11, 2022
@meganrogge meganrogge added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream labels Feb 11, 2022
@meganrogge meganrogge mentioned this issue Feb 11, 2022
Closed
@meganrogge
Copy link
Contributor Author

xtermjs/xterm.js#3636

@meganrogge
Copy link
Contributor Author

meganrogge commented Feb 12, 2022 •
edited

to verify:

  • enable shell integration
  • run some commands (you should see a decoration appear for each)
  • type vim or similar

expectation:

  • the decorations aren't showing with vim open
  • exit vim via :q enter
  • the decorations should be visible

@roblourens roblourens added the verified Verification succeeded label Feb 25, 2022
@Tyriar Tyriar added the terminal-shell-integration Shell integration, command decorations, etc. label Feb 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2022
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@meganrogge
update xterm@4.18.0-beta.5 fix microsoft#142859
98b5760
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Projects
None yet
Milestone
February 2022
Development

No branches or pull requests
4 participants
@roblourens @Tyriar @meganrogge and others