Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request feature "Integrated terminal" #143

Closed
kkdai opened this issue Nov 19, 2015 · 121 comments
Closed

Request feature "Integrated terminal" #143

kkdai opened this issue Nov 19, 2015 · 121 comments
Assignees
Labels
feature-request Request for new features or functionality terminal Integrated terminal issues
Milestone

Comments

@kkdai
Copy link

kkdai commented Nov 19, 2015

It would be great if vscode has integrated terminal feature refer vim or atom https://atom.io/packages/term3

I saw this suggestion pending in uservoice(https://visualstudio.uservoice.com/forums/293070-visual-studio-code/suggestions/7752357-integrated-terminal) and repost here since it has specific repo

@meritozh
Copy link

+1.
term3 can't support zsh well, and it will make atom slowly. Hope vscode can solve it.

@Alsmile
Copy link

Alsmile commented Nov 19, 2015

+1

2 similar comments
@Alsmile
Copy link

Alsmile commented Nov 19, 2015

+1

@codewithtyler
Copy link

+1

@joaomoreno
Copy link
Member

Personally I think this is a bad idea. Making the editor a kitchen sink is how we will make it slow and bloated. Besides, the amount of work necessary to get on par with just the basic features of excellent terminals out there (e.g. iTerm2, ConEmu) would be huge.

I know not everyone runs OS X but check out my setup below. I'm using El Capitan's full screen features to place VS Code side by side with iTerm2. I am super happy with it.

image

@meritozh
Copy link

@joaomoreno but some people want coding, and just use CLT when deploy app. Maybe you can make a extension like term3, then the native version of VSCode won't run slowly.

@joaomoreno
Copy link
Member

That is an opportunity for an extension: deployment commands!

@meritozh
Copy link

Yes, you're right. By the way, why i can't search in extension market?

@alexdima alexdima added the feature-request Request for new features or functionality label Nov 30, 2015
@egamma egamma modified the milestone: Backlog Dec 10, 2015
@ashw1984
Copy link

+1

2 similar comments
@animator013
Copy link

+1

@adrian-castravete
Copy link

👍

@nhack
Copy link

nhack commented Feb 3, 2016

is there an extension that offers a terminal? anyhow +1

@edgariscoding
Copy link

+1

@TemaSM
Copy link

TemaSM commented Feb 16, 2016

+1 For built in or as extension

@maximpashuk
Copy link

+1 also

@Widcket
Copy link

Widcket commented Mar 1, 2016

+1 for built in, as in the CodeRunner mac app

@jagreehal
Copy link

+1

1 similar comment
@leonardosnt
Copy link

+1

@aaronoah
Copy link

aaronoah commented Mar 3, 2016

Yah, definitely need it! +1

@opsnull
Copy link

opsnull commented Mar 4, 2016

+1

2 similar comments
@rosskhanas
Copy link

+1

@vanshady
Copy link

vanshady commented Mar 7, 2016

+1

@pflannery
Copy link

As an extension I agree but not integrated in to the editor itself.
Ultimately I would like to see a terminal extension that gives multi terminal capabilities like web storm does.

I think the goal should be to get vscode extensible enough that someone can do extensions like this.
i.e. able to add\extend panels with tabs\sidebars etc..

I find ctrl+shift+c is doing the job ok for now (minus the part that I cant choose which terminal program it launches)

@stylemistake
Copy link

I find ctrl+shift+c is doing the job ok for now (minus the part that I cant choose which terminal program it launches)

@pflannery That's a problem too, and I think it should be solved in first place. In Xfce there is no gnome-terminal, and I could be probably using better terminals even on Windows/OSX (hypothetically), so having a config option to select which terminal I want to launch would be good enough for me. Built-in terminal = reinventing the wheel.

@pflannery
Copy link

@stylemistake your right, basic terminal launching should work on linux. Could be worth raising an separate issue if not already done so.
I have a PR for using better terminals but it's only for windows so far. PR #3495.

@ghost
Copy link

ghost commented Mar 9, 2016

+1

@chevcast
Copy link

chevcast commented Mar 9, 2016

I'm actually fine with the terminal being separate by default. How hard would it be to make an extension that adds this though? That would be awesome.

@Tyriar
Copy link
Member

Tyriar commented May 23, 2016

@whitecolor F1, type "settings", enter should open your user settings.json file, you add it there.

@wclr
Copy link

wclr commented May 23, 2016

Hm I added setting, mark use legacy terminal in cmd settings.

I press ctrl+ but it just jumps next tab. An I have noview` menu at all in the UI.

@Tyriar
Copy link
Member

Tyriar commented May 23, 2016

@whitecolor it will land in stable in early June and in the Insiders build in a few days.

@wclr
Copy link

wclr commented May 23, 2016

ok, will it support multiple terminals per opened project?

@Tyriar
Copy link
Member

Tyriar commented May 23, 2016

@whitecolor only a single terminal per vscode windows in Stable, #6458 tracks multiple terminals.

@AlexJuca
Copy link

This feature should definitely be built. I was debugging some ruby code and I had to interact with the terminal to enter some input that the program needs and bam! No terminal for me to interact with.

@Tyriar
Copy link
Member

Tyriar commented May 25, 2016

After trying again on Windows 10 with the new cmd, it seems to work just fine. As such I think I'll make the default %COMSPEC% which points at cmd by default. This makes it consistent with the open in (external) terminal command. #6886

@builden
Copy link

builden commented May 31, 2016

in chinese system show confusiton code
image

Version 1.2.0 insider

@Tyriar
Copy link
Member

Tyriar commented May 31, 2016

@builden What does it show when you run the same command in the native terminal outside of vscode?

@builden
Copy link

builden commented May 31, 2016

@Tyriar
image

@Tyriar
Copy link
Member

Tyriar commented May 31, 2016

@builden thanks, looks like the CJK chars are stacked on top of each other. Looks like it was just filed here #7036

@builden
Copy link

builden commented May 31, 2016

@Tyriar Great
have another question:
{ "key": "ctrl+`", "command": "workbench.action.terminal.toggleTerminal" },
this shortcut is invalidation

@Tyriar
Copy link
Member

Tyriar commented May 31, 2016

@builden what keyboard layout are you using?

@builden
Copy link

builden commented May 31, 2016

@Tyriar like this
image

@Tyriar
Copy link
Member

Tyriar commented May 31, 2016

@builden So the key next to 1 doesn't work? Works from the testing I've done on Mac/Windows/Linux using US keyboard layout (which seems to be the same).

@builden
Copy link

builden commented May 31, 2016

@Tyriar i change shortcut string can work fine
image

@builden
Copy link

builden commented May 31, 2016

@Tyriar I have find the reason, ctrl+` have used by other application

@Tyriar
Copy link
Member

Tyriar commented May 31, 2016

@builden was it cmder that's using the keybinding?

@builden
Copy link

builden commented Jun 1, 2016

@Tyriar It's my Chinese input application "QQ Pinyin"

@Tyriar
Copy link
Member

Tyriar commented Jun 1, 2016

@builden ah, I think that's pretty command for keybindings to break when an IME is active.

@builden
Copy link

builden commented Jun 1, 2016

@Tyriar I have closed the IME keybinding, but another person is hard to find which app have binded the command

@willin
Copy link

willin commented Jun 2, 2016

@Tyriar how to use in os x

{ "key": "ctrl+shift+t",          "command": "launcher.terminal" }

no use

@builden
Copy link

builden commented Jun 2, 2016

@Tyriar In Windows, I can't copy string from terminal page, I think this feature is necessary

@Tyriar
Copy link
Member

Tyriar commented Jun 2, 2016

@willin try this:

{ "key": "ctrl+shift+t", "command": "workbench.action.terminal.toggleTerminal" },

@builden polishing the copy and paste experience is planned for the June release #6451

@Tyriar
Copy link
Member

Tyriar commented Jun 2, 2016

Thanks everyone for your contributions! I'm going to lock the conversation to prevent pinging all the participants for smaller issues. If you find any other problems please check out the existing issue list and create a new one if necessary.

@microsoft microsoft locked and limited conversation to collaborators Jun 2, 2016
@Tyriar
Copy link
Member

Tyriar commented Jun 10, 2016

See #7302 (comment) for the proposed default keybindings used by the terminal.

@Tyriar
Copy link
Member

Tyriar commented Jun 27, 2016

You can see a glimpse of what's coming in v1.3.0 in the June test plan: #8222

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests