Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command decorations don't have button styling on hover / mouse pointer #143402

Closed
meganrogge opened this issue Feb 18, 2022 · 2 comments · Fixed by #143404
Closed

command decorations don't have button styling on hover / mouse pointer #143402

meganrogge opened this issue Feb 18, 2022 · 2 comments · Fixed by #143404
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Milestone
February 2022

Comments

@meganrogge
Copy link
Contributor

No description provided.

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal-command-decoration labels Feb 18, 2022
@meganrogge meganrogge added this to the February 2022 milestone Feb 18, 2022
meganrogge added a commit that referenced this issue Feb 18, 2022
@meganrogge
fix #143402 and change skipped -> default
a1a4d22
@meganrogge meganrogge linked a pull request Feb 18, 2022 that will close this issue
show outline on command start and rename command icon colors #143404
Merged
@mjbvz mjbvz added the verification-steps-needed Steps to verify are needed for verification label Feb 25, 2022
@mjbvz
Copy link
Contributor

mjbvz commented Feb 25, 2022 •
edited

@meganrogge Can you please clarify how to verify this?

@meganrogge
Copy link
Contributor Author

On hover of the decorations, you should see a background that is similar to how other buttons look in the workbench when hovered. You shouldn't see this for skipped commands ie the grey circle outline decorations, but should for the other two.

@meganrogge meganrogge removed the verification-steps-needed Steps to verify are needed for verification label Feb 25, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Feb 25, 2022
@Tyriar Tyriar added the terminal-shell-integration Shell integration, command decorations, etc. label Feb 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
February 2022
Development

Successfully merging a pull request may close this issue.

show outline on command start and rename command icon colors microsoft/vscode
4 participants
@Tyriar @mjbvz @meganrogge @joyceerhl