Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: terminal command decorations #143433

Closed
3 tasks done
meganrogge opened this issue Feb 19, 2022 · 1 comment
Closed
3 tasks done

Test: terminal command decorations #143433

meganrogge opened this issue Feb 19, 2022 · 1 comment

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Feb 19, 2022

Refs: #140308

Complexity: 4

Authors: @meganrogge, @Tyriar

Create Issue


The terminal now features "shell integration" with the opt-in setting terminal.integrated.shellIntegration.enabled.

See #141339 for details.

Since a shell script needs to be written on a shell-by-shell basis, only the following are currently supported:

  • Windows
    • pwsh (6+, not "Windows PowerShell")
  • Linux/macOS
    • pwsh
    • bash
    • NOT zsh for now

We have added command decorations decorations (codicons) in order to bring awareness to some of the new insights and capabilities shell integration provides.

We have 3 decoration styles:

  • default - a hollow, grey circle
  • error - a red circle with an x
  • success - a blue filled circle

Verify that:

  • for default commands:
    • nothing was entered and there was no output
    • when you hover them, nothing happens
    • you can't click them
  • for error commands
    • the command had a non-zero exit code
    • on hover, you see the exit code
    • on click, you can re run the command or copy the output
  • for success commands:
    • the command's exit code was zero
    • on click, you can re run the command or copy the output

Some things to try:

  • run clear and similar commands - the decorations should disappear
  • scroll - make sure they show and hide appropriately
  • anything else you can think of
  • change the renderer type via terminal.integrated.gpuAcceleration
  • set the terminal.integrated.shellIntegration.commandIcon settings to new codicon IDs and empty strings and verify that works

Here are some of the main limitations you may hit while testing:

@bpasero bpasero added this to the February 2022 milestone Feb 19, 2022
@joaomoreno joaomoreno removed their assignment Feb 23, 2022
@joyceerhl joyceerhl removed their assignment Feb 23, 2022
@paulacamargo25 paulacamargo25 removed their assignment Feb 24, 2022
@paulacamargo25
Copy link
Contributor

I'm closing the issue even though there are some open bugs, please let me know if that isn't the right thing to do.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants