Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

higlightActiveIndentation conflicts with bracketPairs in JSX/TSX #143484

Closed
rolandleth opened this issue Feb 20, 2022 · 5 comments
Closed

higlightActiveIndentation conflicts with bracketPairs in JSX/TSX #143484

rolandleth opened this issue Feb 20, 2022 · 5 comments
Assignees
Labels
bracket-pair-guides insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@rolandleth
Copy link

rolandleth commented Feb 20, 2022

Does this issue occur when all extensions are disabled?: No

VS Code Version: 1.64
OS Version: Mac Monterey
Steps to Reproduce:

When only editor.guides.highlightActiveIndentation is enabled, the HTML active indentation in TSX shows correctly
141713992-46c5f550-1b7c-4a62-9dde-e4368ff34da1

But after enabling editor.guides.bracketPairs at the same time, the HTML active indentation in TSX gets disabled
141714021-2a9f8c51-b3ec-4d73-99f4-7d8af7306641

Please don’t mark this as a feature request, because it’s clearly missing functionality, functionality that Bracket Pair Colorizer had (which is now discontinued).

If we can agree that this is useful in pure HTML, then we can agree that not having it in TSX is detrimental.

@hediet
Copy link
Member

hediet commented Feb 21, 2022

Please reference any related issues (in this case #137190), that helps us a lot.

I'll keep this open as the original duplicate has been closed automatically.

@rolandleth
Copy link
Author

Sorry, didn't realise linking it would help 🙈 Thanks for keeping it open! If there's any other info/input I can help with, let me know.

@hediet
Copy link
Member

hediet commented Apr 21, 2022

With tomorrows insiders build, you can set this:

"editor.guides.highlightActiveIndentation": "always",

Which will cause the desired behavior:

image

The default behavior remains unchanged:

"editor.guides.highlightActiveIndentation": true,

image

@isidorn what do you think of the name of the setting value?

@hediet hediet closed this as completed in 1ccee4a Apr 21, 2022
@isidorn
Copy link
Contributor

isidorn commented Apr 21, 2022

@hediet I find the difference between true and always very hard to understand by the user :)
Why don't we just behave like this by default? What is the downside? You are worried about two active indentations at the same time?

@hediet
Copy link
Member

hediet commented Apr 26, 2022

What is the downside? You are worried about two active indentations at the same time?

If set to always, there would always be both the indentation guide and the bracket pair guide, not necessarily aligning. Because the bracket pair guide is more precise, the idea was to not show the active indentation guide (this was a feature request early on from @alexdima).

I also have a slight preference for the current default, but don't really mind.

aeschli pushed a commit that referenced this issue May 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bracket-pair-guides insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

No branches or pull requests

5 participants
@rolandleth @isidorn @hediet @alexr00 and others