Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow getWorker function to return a promise #143611

Merged
merged 1 commit into from Feb 22, 2022

Conversation

CGNonofr
Copy link
Contributor

@ghost
Copy link

ghost commented Feb 22, 2022

CLA assistant check
All CLA requirements met.

@hediet
Copy link
Member

hediet commented Feb 22, 2022

Thank you!

Reference:

function getWorker(label: string): Worker | Promise<Worker> {
// Option for hosts to overwrite the worker script (used in the standalone editor)
if (globals.MonacoEnvironment) {
if (typeof globals.MonacoEnvironment.getWorker === 'function') {
return globals.MonacoEnvironment.getWorker('workerMain.js', label);
}

Since this is a type declaration change that only affects monaco, we can include this fix in this milestone.

@hediet hediet merged commit 8421620 into microsoft:main Feb 22, 2022
@hediet hediet assigned hediet and unassigned alexdima Feb 22, 2022
@hediet hediet added this to the February 2022 milestone Feb 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] getWorker method type is too restrictive
3 participants