Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize layout visibility buttons should say what the buttons do instead of the current view state #143829

Closed
mjbvz opened this issue Feb 23, 2022 · 1 comment · Fixed by #170236
Closed

Customize layout visibility buttons should say what the buttons do instead of the current view state #143829

mjbvz opened this issue Feb 23, 2022 · 1 comment · Fixed by #170236
Assignees
@sbatten
Labels
insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues polish Cleanup and polish issue
Milestone
January 2023

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Feb 23, 2022

Testing #143581

  1. Open the 'customize layout' control
  2. Hover over one of the visibility buttons for something like the side bar

Bug
If the side bar is visible, the hover will say Side bar (visible). Instead I think the title should tell the user that clicking the button will hide the side bar
@sbatten
Copy link
Member

sbatten commented Feb 24, 2022

@misolori do we have pre-existing guidelines for this?

@sbatten sbatten added the under-discussion Issue is under discussion for relevance, priority, approach label Feb 24, 2022
@sbatten sbatten mentioned this issue Dec 29, 2022
Merged
sbatten added a commit that referenced this issue Dec 29, 2022
@sbatten
update toggle text in customize layout
db80ec2 
fixes #143829
@sbatten sbatten added polish Cleanup and polish issue layout General VS Code workbench layout issues and removed under-discussion Issue is under discussion for relevance, priority, approach labels Dec 29, 2022
@sbatten sbatten added this to the January 2023 milestone Dec 29, 2022
sbatten added a commit that referenced this issue Dec 29, 2022
@sbatten
update toggle text in customize layout (#170236)
8b5e6be 
fixes #143829
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues polish Cleanup and polish issue
Projects
None yet
Milestone
January 2023
Development

Successfully merging a pull request may close this issue.

update toggle text in customize layout microsoft/vscode
3 participants
@sbatten @mjbvz @VSCodeTriageBot