Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run zsh startup files #144196

Merged
merged 6 commits into from Mar 1, 2022
Merged

run zsh startup files #144196

merged 6 commits into from Mar 1, 2022

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Mar 1, 2022 •
edited

This PR fixes #144141

@meganrogge meganrogge self-assigned this Mar 1, 2022
@meganrogge meganrogge added this to the February 2022 milestone Mar 1, 2022
@meganrogge meganrogge requested a review from Tyriar March 1, 2022 18:36
@meganrogge
Copy link
Contributor Author

Trying to figure out why all of the startup files are still running when I delete the login args from zsh

@meganrogge
Copy link
Contributor Author

meganrogge commented Mar 1, 2022 •
edited

The available profiles from terminalProfileService always use the default args for zsh, [-l], even when that's changed.
Screen Shot 2022-03-01 at 12 50 24 PM
logged that here

vscode/src/vs/workbench/contrib/terminal/browser/terminalService.ts

Line 928 in 07aa73b


when I have

 "zsh": {
      "path": "zsh",
    },

or

 "zsh": {
      "path": "zsh",
      "args": []
    },

@meganrogge meganrogge mentioned this pull request Mar 1, 2022
Closed
@meganrogge meganrogge requested a review from Tyriar March 1, 2022 20:24
@Tyriar Tyriar added the candidate Issue identified as probable candidate for fixing in the next release label Mar 1, 2022
@meganrogge @Tyriar
Update src/vs/workbench/contrib/terminal/browser/media/shellIntegrati…
52123aa 
…on.zsh

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge meganrogge merged commit c9fad5a into main Mar 1, 2022
@meganrogge meganrogge deleted the merogge/zsh-fix branch March 1, 2022 21:41
@Tyriar Tyriar removed the candidate Issue identified as probable candidate for fixing in the next release label Mar 1, 2022
meganrogge added a commit that referenced this pull request Mar 1, 2022
@meganrogge @Tyriar
run zsh startup files (#144196)
d423d78 

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
meganrogge added a commit that referenced this pull request Mar 1, 2022
@meganrogge @Tyriar
run zsh startup files (#144196) (#144210)
8b889f1 
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
February 2022
Development

Successfully merging this pull request may close these issues.

.zshrc isn't run when using zsh with shell integration enabled
2 participants
@meganrogge @Tyriar