Add a setting to ignore dirty tabs in workbench.editor.limit.value

[buggymcbugfix]

I have long been looking for a way to keep my tabs tidy and was extremely happy to find the workbench.editor.limit feature.
Per @bpasero #9872 (comment), dirty tabs count towards the editor tabs limit. This is unfortunate, because I often have several dirty tabs and once their number approaches the open tabs limit, I no longer get to open several clean tabs in parallel. I would like to have an option for workbench.editor.limit.value to ignore dirty tabs.

[bpasero]

What happens when a dirty tab is getting closed due to the limit? You still need to get asked for saving or reverting no?

[buggymcbugfix]

I would like dirty tabs to never get auto-closed (same behaviour as now). Dirty tabs should simply not count towards the limit. If my limit is 3 and I have 5 dirty tabs, then I still want to be able to open 3 clean tabs.

[bpasero]

Oh I see.

[bpasero]

I think this can be done by a contribution via PR behind a new setting, relevant code piece is:

vscode/src/vs/workbench/browser/parts/editor/editorsObserver.ts

Line 341 in cc76605

private async doEnsureOpenedEditorsLimit(limit: number, mostRecentEditors: IEditorIdentifier[], exclude?: IEditorIdentifier): Promise<void> {

[luoriyuhui21]

hello，could I work on this issue as my first one ？

[bpasero]

Yes, anyone can work on this 👍

[luoriyuhui21]

this pr is as
#144545

[bpasero]

Thanks, will take a look later this month.

[buggymcbugfix]

thanks @bpasero @luoriyuhui21 ❤️

[bpasero]

Verification: play with the new workbench.editor.limit.excludeDirty setting and ensure it is working as advertised.

[lramos15]

@bpasero This setting is sort of what I do with the tabs API sample. I wonder if we should just have an extension which implements all these caveats.