Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor limit only updates on editor open #148198

Closed
lramos15 opened this issue Apr 26, 2022 · 2 comments
Closed

Editor limit only updates on editor open #148198

lramos15 opened this issue Apr 26, 2022 · 2 comments
Assignees
Labels
*as-designed Described behavior is as designed polish Cleanup and polish issue

Comments

@lramos15
Copy link
Member

Found verifying: #144309

  1. Have exclude dirty on and a small editor limit (I chose 1)
  2. Have one dirty file and one non dirty file
  3. Undo the dirty changes
  4. 馃悰 You have two clean files open even though your limit is 1.

This feels like polish and isn't a huge deal but maybe we want to listen to a few more events here or use tabs API.

@lramos15 lramos15 added the polish Cleanup and polish issue label Apr 26, 2022
@bpasero bpasero added the *as-designed Described behavior is as designed label Apr 27, 2022
@bpasero
Copy link
Member

bpasero commented Apr 27, 2022

I worry to change this behaviour because editor limit has been there since >1y and I did not hear feedback from users that would expect non-dirty editors to close when they are saved or reverted.

@bpasero bpasero closed this as not planned Won't fix, can't repro, duplicate, stale Apr 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

3 participants
@bpasero @lramos15 and others