Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unoptimized file diff in jupyter notebooks #144578

Closed
bleamer opened this issue Mar 7, 2022 · 1 comment
Closed

Unoptimized file diff in jupyter notebooks #144578

bleamer opened this issue Mar 7, 2022 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) notebook-diff
Milestone

Comments

@bleamer
Copy link

bleamer commented Mar 7, 2022

Issue Type: Bug

File comparison between version on VSCode for Jupyter notebook can be improved.
Steps to reproduce:

  • Modify a cell in Jupyter notebook
  • Add 2-3 non-empty new cells below the modified cell
  • Observe the diff does not align the earlier modified cell correctly and tried to compare with newly added cell.

IN contrast nbdiff-web is able to catch this difference.

VS Code version: Code 1.65.0 (Universal) (b5205cc, 2022-03-02T11:11:20.886Z)
OS version: Darwin x64 20.6.0
Restricted Mode: No

Extensions (16)
Extension Author (truncated) Version
jupyter-keymap ms- 1.0.0
remote-containers ms- 0.224.2
remote-ssh ms- 0.76.1
remote-wsl ms- 0.64.2
vscode-remote-extensionpack ms- 0.21.0
gitlens eam 12.0.1
gitkraken-authentication git 1.0.3
python-resource-monitor kai 0.1.9
json-table-viewer len 0.0.4
rainbow-csv mec 2.0.0
python ms- 2022.2.1924087327
vscode-pylance ms- 2022.3.0
jupyter ms- 2022.2.1020642448
jupyter-keymap ms- 1.0.0
jupyter-renderers ms- 1.0.6
vscode-progressive-increment nar 1.0.3
@rebornix rebornix added this to the On Deck milestone Mar 7, 2022
@rebornix rebornix added the under-discussion Issue is under discussion for relevance, priority, approach label Dec 2, 2022
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Dec 19, 2022
@rebornix
Copy link
Member

/duplicate of #133645

@VSCodeTriageBot VSCodeTriageBot added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) notebook-diff
Projects
None yet
Development

No branches or pull requests

5 participants
@rebornix @bleamer @greazer @VSCodeTriageBot and others