Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diffing view marks all cells after the newly-added cell as changed, decreasing its usefulness #133645

Closed
ronglums opened this issue Sep 22, 2021 · 0 comments
Closed

Diffing view marks all cells after the newly-added cell as changed, decreasing its usefulness #133645

ronglums opened this issue Sep 22, 2021 · 0 comments
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-diff verified Verification succeeded
Milestone
January 2023

Comments

@ronglums
Copy link

VS Code 1.61.0-insider + Jupyter extension v2021.9.1001261101

  1. open an ipynb file
  2. add a new cell in the middle of the notebook
  3. open the diff view from the git sidebar

expected: only the newly added cell is highlighted as changed
actual: all cells after the newly-added cell are marked changed, even though their content has no change. This makes hard for users to spot "real changes" in the diff view.

please refer to this video 30'55'' - 32'22''
https://msit.microsoftstream.com/video/12e10840-98dc-ae71-db7b-f1ec19e01ea4?list=studio
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-jupyter Sep 23, 2021
@rebornix rebornix added notebook-diff under-discussion Issue is under discussion for relevance, priority, approach labels Oct 11, 2021
@burkeholland burkeholland mentioned this issue Jun 9, 2022
Open
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Dec 19, 2022
@roblourens roblourens removed their assignment Dec 22, 2022
@rebornix rebornix added this to the January 2023 milestone Dec 28, 2022
rebornix added a commit that referenced this issue Dec 28, 2022
@rebornix
Fix #133645. Normalize EOL.
1428ed9
This was referenced Dec 28, 2022
Closed
Closed
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 28, 2022
@roblourens roblourens added the verified Verification succeeded label Jan 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-diff verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

No branches or pull requests
5 participants
@roblourens @rebornix @DonJayamanne @ronglums @VSCodeTriageBot