Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve editor relative sizes when switching layouts #14464

Closed
Tyriar opened this issue Oct 25, 2016 · 3 comments
Closed

Preserve editor relative sizes when switching layouts #14464

Tyriar opened this issue Oct 25, 2016 · 3 comments
Assignees
@bpasero
Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
January 2017

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 25, 2016

Testing #14016

  • VSCode Version: Code - Insiders 1.7.0-insider (5bafcdb, 2016-10-25T06:19:07.301Z)
  • OS Version: Linux x64 4.4.0-45-generic, Ubuntu 16.04
  • Extensions:
Extension Author Version
EditorConfig EditorConfig 0.3.4
lorem-ipsum Tyriar 1.0.0
sort-lines Tyriar 1.1.0
terminal-tabs Tyriar 0.0.6
theme-glacier Tyriar 0.0.10
vscode-icontheme-nomo-dark be5invis 1.1.5
vscode-svgviewer cssho 1.2.0
vscode-eslint dbaeumer 1.0.8
git-project-manager felipecaputo 0.1.15
Theme-Wombat gerane 0.0.2
csharp ms-vscode 1.4.1
typescript-javascript-grammar ms-vscode 0.0.6
nova rebornix 0.0.5
sass-indented robinbentley 1.1.0
annotator ryu1kn 0.10.1

Steps to Reproduce:

  1. Open 2 editor groups
  2. "Minimize" one to enable snapping
  3. Toggle editor group layout, the editor groups will both be the default sizes.
@Tyriar Tyriar added ux User experience issues workbench-tabs VS Code editor tab issues labels Oct 25, 2016
@rebornix
Copy link
Member

After the third step @Tyriar mentioned above, if you do a fourth step Toggle editor group layout which switches back the previous layout, snapping state should be retained at least.

@bpasero bpasero changed the title Editor group snap state should be retained when toggling editor group layout Preserve editor relative sizes when switching layouts Oct 26, 2016
@bpasero bpasero added help wanted Issues identified as good community contribution opportunities feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors labels Oct 26, 2016
@bpasero bpasero removed their assignment Oct 26, 2016
@bpasero bpasero removed the workbench-tabs VS Code editor tab issues label Oct 28, 2016
@charlespierce
Copy link
Contributor

I'm interested in tackling this feature request. From a quick look, it appears to be relatively straightforward, but I'm curious if there are any potential pitfalls that immediately jump out to be aware of?

@charlespierce charlespierce mentioned this issue Dec 23, 2016
Merged
charlespierce added a commit to charlespierce/vscode that referenced this issue Jan 4, 2017
@charlespierce
microsoft#14464 Preserve editor size when switching layout
c4347fc
charlespierce added a commit to charlespierce/vscode that referenced this issue Jan 4, 2017
@charlespierce
microsoft#14464 Remove KEEP_RATIO from the exposed API
38038ba
bpasero added a commit that referenced this issue Jan 5, 2017
@bpasero
Merge pull request #17760 from charlespierce/preserve_layout
c43059c 
#14464 Preserve editor size when switching layout
@bpasero bpasero added the verification-needed Verification of issue is requested label Jan 5, 2017
@bpasero bpasero added this to the January 2017 milestone Jan 5, 2017
@bpasero bpasero self-assigned this Jan 5, 2017
@bpasero bpasero closed this as completed Jan 5, 2017
@bpasero
Copy link
Member

bpasero commented Jan 23, 2017

  • To verify:
    Switch the editor layout and verify the editor dimensions are kept relatively.

@Tyriar Tyriar added the verified Verification succeeded label Jan 25, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
January 2017
Development

No branches or pull requests
4 participants
@rebornix @bpasero @Tyriar @charlespierce