Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expandLineSelection should include trailing \n #14485

Closed
waderyan opened this issue Oct 25, 2016 · 2 comments · Fixed by #15564
Closed

expandLineSelection should include trailing \n #14485

waderyan opened this issue Oct 25, 2016 · 2 comments · Fixed by #15564
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug editor-core Editor basic functionality verified Verification succeeded
Milestone
February 2017

Comments

@waderyan
Copy link

waderyan commented Oct 25, 2016 •
edited

In other editors expandLineSelection will also include the trailing \n.

Edit: to solve typo
@waderyan waderyan mentioned this issue Oct 25, 2016
Closed
@Bill-Stewart
Copy link

Bill-Stewart commented Oct 25, 2016 •
edited

I agree. Or it should at least be an option.

@waderyan
Copy link
Author

Whoops yes I do. Edited

@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Oct 26, 2016
@alexdima alexdima added this to the Backlog milestone Oct 26, 2016
@alexdima alexdima added the editor-core Editor basic functionality label Oct 26, 2016
@kaiwood kaiwood mentioned this issue Nov 16, 2016
Merged
kaiwood pushed a commit to kaiwood/vscode that referenced this issue Dec 1, 2016
Include newline when expanding line selection
083dff8 
Fixes microsoft#14485
@alexdima alexdima modified the milestones: February 2017, Backlog Feb 20, 2017
@aeschli aeschli mentioned this issue Feb 24, 2017
Closed
@aeschli aeschli added the verified Verification succeeded label Feb 24, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug editor-core Editor basic functionality verified Verification succeeded
Projects
None yet
Milestone
February 2017
Development

Successfully merging a pull request may close this issue.

Include newline when expanding line selection kaiwood/vscode
4 participants
@waderyan @alexdima @aeschli @Bill-Stewart