Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[theme] Typescript: argument values not colored #1452

Closed
isidorn opened this issue Dec 18, 2015 · 2 comments
Closed

[theme] Typescript: argument values not colored #1452

isidorn opened this issue Dec 18, 2015 · 2 comments
Assignees
@aeschli
Milestone
Backlog

Comments

@isidorn
Copy link
Contributor

isidorn commented Dec 18, 2015

Notice how 6 and false are not colored

screen shot 2015-12-18 at 16 13 52
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Dec 18, 2015
@bpasero bpasero added this to the Backlog milestone Dec 19, 2015
@aeschli aeschli changed the title Typescript: argument values not colored [theme] Typescript: argument values not colored Jan 12, 2016
@aeschli
Copy link
Contributor

aeschli commented Jan 12, 2016

Scope of 6 is token block body constant declaration function meta method numeric object parameter type ts
Problem is that parameter.type is stronger than constant.

It's a consequence of us flattening all the tm scopes. No easy fix here.

@aeschli
Copy link
Contributor

aeschli commented Mar 17, 2016

duplicate of #3008

@aeschli aeschli closed this as completed Mar 17, 2016
@aeschli aeschli removed the bug Issue identified by VS Code Team member as probable bug label Mar 18, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@bpasero @isidorn @aeschli