zsh suggestion is hidden when enable shellIntegration

[tjx666]

• VS Code Version: 1.66.0-insider
• OS Version: MacOS 12.3

In iterm2:

In VSCode terminal when enable shellIntegration:

If I disable shellIntegration, everything goes ok:

[meganrogge]

related to #145254

[meganrogge]

I believe this is already fixed, can you see if you can reproduce in the Insiders build?
/"needs-more-info"

[JacksonKearl]

Not quite yet... this is why I personally have shell integration disabled btw.

[meganrogge]

This is working for me

Here's what I did

from https://github.com/zsh-users/zsh-autosuggestions/blob/master/INSTALL.md

[meganrogge]

@JacksonKearl has reported it does not work if you just have plugins=(git zsh-autosuggestions) in your .zshrc

[JacksonKearl]

Looks like suggestion text does show up, but it uses a different history file. So it will suggest entries you have made with shell integration enabled, but not those made in normal terminals.

[meganrogge]

@Tyriar should it be using the same history file?

[Tyriar]

@meganrogge is this fine now because we revert $ZDOTDIR to the original? We definitely want to share the zsh history file.

[meganrogge]

@Tyriar it's using the history from within VS Code only - when should it get refreshed and also suggest things from the broad shell history? tried reloading the window

[meganrogge]

also does not pull from history of terminals that did not have shell integration enabled

[Tyriar]

@meganrogge it depends when zsh flushes history to ~/.zsh_history, not sure if it's when the shell closes or a command is run.

[meganrogge]

hmm history is correct for terminals without shell integration, but not in ones w shell integration - even when I reload the window and create a new one

[Tyriar]

@meganrogge what's $HISTFILE set to?

[meganrogge]

[Tyriar]

I'm guessing we need to fix up $HISTFILE as well to point at <original ZDOTDIR or ~>/.zsh_history?

[fredrikaverpil]

@Tyriar @meganrogge would you think my McFly error is related to the above discussion? (Cc @cantino)

After a touch /var/folders/cp/njmrk_0j57q3t5c8666fqr0r0000gn/T/vscode-zsh/.zsh_history my prompt looks normal again:

I believe this usually happens when vscode is updated ...?

EDIT: I just found a pre-existing issue in the mcfly repo here.

[Tyriar]

@fredrikaverpil we expect this to be fixed in the upcoming version, see #157128

Sorry about the hassle, please let us know if it's not fixed in 1.71