Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shell integration functions should be renamed #145584

Closed
meganrogge opened this issue Mar 21, 2022 · 3 comments · Fixed by #145614, #145799 or #145885
Closed

shell integration functions should be renamed #145584

meganrogge opened this issue Mar 21, 2022 · 3 comments · Fixed by #145614, #145799 or #145885
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Milestone
March 2022

Comments

@meganrogge
Copy link
Contributor

  • Breaks when user rc files define precmd or preexec (this is fairly common).
  • Breaks when user rc files define update_prompt, command_complete or similar. These names aren’t special but they look reasonable enough to have a chance of being defined, which would cause a clash.
    Originally posted by @romkatv in Support common prompts with shell integration #142004 (comment)
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration, command decorations, etc. labels Mar 21, 2022
@meganrogge meganrogge added this to the March 2022 milestone Mar 21, 2022
@Tyriar Tyriar mentioned this issue Mar 21, 2022
Closed
@Tyriar
Copy link
Member

Tyriar commented Mar 21, 2022

Forked precmd/preexec parts to #145612

Tyriar added a commit that referenced this issue Mar 21, 2022
@Tyriar
Use prefix to avoid clashes with shell functions
6032c70 
Fixes #145584
@Tyriar Tyriar mentioned this issue Mar 21, 2022
Merged
@Tyriar
Copy link
Member

Tyriar commented Mar 22, 2022

Need to do the same for variables too

@Tyriar Tyriar reopened this Mar 22, 2022
@meganrogge meganrogge mentioned this issue Mar 22, 2022
Merged
@Tyriar
Copy link
Member

Tyriar commented Mar 23, 2022

We missed some #145799 (comment)

@Tyriar Tyriar reopened this Mar 23, 2022
Tyriar added a commit that referenced this issue Mar 23, 2022
@Tyriar
Prefix all variables with __vsc_ to avoid conflicts with user scripts
6cc7f23 
Fixes #145584
@Tyriar Tyriar mentioned this issue Mar 23, 2022
Merged
@connor4312 connor4312 added the verified Verification succeeded label Mar 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
March 2022
4 participants
@Tyriar @connor4312 @meganrogge and others