Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"explorer.fileNesting.operateAsGroup" weird setting and weirder semantics #145665

Closed
isidorn opened this issue Mar 22, 2022 · 5 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 22, 2022

Testing #145640

imho all operations on the parent resource should affect the child resource. Same as with folders.
Why do we make this configurable? Do users actually not expect this and want to change this? Why is the default false?

If we really decide that a setting for this is needed then operateAsGroup is misleading because it is not actually a group. All operations on the child are not done on the parent.

@isidorn isidorn added the file-explorer Explorer widget issues label Mar 22, 2022
@JacksonKearl
Copy link
Contributor

JacksonKearl commented Mar 23, 2022

The main problem I saw was how do we make it possible to only copy the single file when you copy a parent. One idea I considered was making the nest operate as a group when it's collapsed, but individual files when it's expanded? That way you would:

  1. collapse the nest and copy it as one item always,
  2. expand the nest and select the subset of entries you want to copy
  3. expand the nest and select just the parent, then only operate on the parent.

what would you think of that flow?

A slight issue there at the moment is the model doesn't know anything about the view's collapse state.

@JacksonKearl JacksonKearl added the feature-request Request for new features or functionality label Mar 23, 2022
@JacksonKearl JacksonKearl added this to the March 2022 milestone Mar 23, 2022
JacksonKearl pushed a commit that referenced this issue Mar 23, 2022
@JacksonKearl
Copy link
Contributor

Enabled the operateAsGroup setting by default though

@JacksonKearl JacksonKearl modified the milestones: March 2022, April 2022 Mar 24, 2022
@isidorn
Copy link
Contributor Author

isidorn commented Mar 24, 2022

@JacksonKearl I like your suggestion to distinguish if collapse or expand and based on that to change behaviour.

gabritto pushed a commit to gabritto/vscode that referenced this issue Mar 25, 2022
@JacksonKearl JacksonKearl added the verification-needed Verification of issue is requested label Apr 28, 2022
@tanhakabir tanhakabir added the verified Verification succeeded label Apr 28, 2022
@tanhakabir
Copy link
Contributor

Getting explorer.fileNesting.operateAsGroup as undefined setting on:

Version: 1.67.0-insider (Universal)
Commit: 7fc8af4
Date: 2022-04-28T05:19:19.018Z
Electron: 17.4.1
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Darwin x64 21.4.0

@tanhakabir tanhakabir removed the verified Verification succeeded label Apr 28, 2022
@JacksonKearl
Copy link
Contributor

Setting is removed sorry. New intended behavior is that it operates as group when collapsed.

@tanhakabir tanhakabir added the verified Verification succeeded label Apr 28, 2022
@JacksonKearl JacksonKearl added the on-release-notes Issue/pull request mentioned in release notes label Apr 30, 2022
aeschli pushed a commit that referenced this issue May 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@isidorn @JacksonKearl @tanhakabir and others