Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings editor list fails to render properly after clearing invalid query #146285

Closed
rzhao271 opened this issue Mar 30, 2022 · 0 comments 路 Fixed by #146306
Closed

Settings editor list fails to render properly after clearing invalid query #146285

rzhao271 opened this issue Mar 30, 2022 · 0 comments 路 Fixed by #146306
Assignees
@rzhao271
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken settings-editor VS Code settings editor issues verified Verification succeeded
Milestone
March 2022 Recovery

Comments

@rzhao271
Copy link
Contributor

rzhao271 commented Mar 30, 2022 •
edited
Loading

  1. Enter a query in the Settings editor that results in a "No settings found" message.
  2. Clear the query.
  3. 馃悰 The Settings editor lists don't render properly.

Screencap demo
@rzhao271 rzhao271 self-assigned this Mar 30, 2022
@rzhao271 rzhao271 added this to the March 2022 milestone Mar 30, 2022
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release settings-editor VS Code settings editor issues regression Something that used to work is now broken labels Mar 30, 2022
This was referenced Mar 30, 2022
Closed
Closed
@rzhao271 rzhao271 changed the title Settings editor list fails to render after clearing invalid query Settings editor list fails to render properly after clearing invalid query Mar 30, 2022
joaomoreno added a commit that referenced this issue Mar 30, 2022
@joaomoreno
fix #146285
68cc4af
@joaomoreno joaomoreno mentioned this issue Mar 30, 2022
Merged
joaomoreno added a commit that referenced this issue Mar 30, 2022
@joaomoreno
fix #146285
d125a24
@joaomoreno joaomoreno mentioned this issue Mar 30, 2022
Merged
joaomoreno added a commit that referenced this issue Mar 30, 2022
@joaomoreno
fix #146285 (#146306)
26020f8
joaomoreno added a commit that referenced this issue Mar 30, 2022
@joaomoreno
fix #146285 (#146307)
db5aa58
@rzhao271 rzhao271 mentioned this issue Mar 31, 2022
Closed
@joaomoreno joaomoreno added the verified Verification succeeded label Apr 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Milestone
March 2022 Recovery
Development

Successfully merging a pull request may close this issue.

Fix #146285 microsoft/vscode
Pass in height to render for list (PR for main) microsoft/vscode
4 participants
@joaomoreno @dbaeumer @rzhao271 and others