Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share a file via vscode.dev link #146309

Closed
tcz717 opened this issue Mar 30, 2022 · 3 comments · Fixed by #152765
Closed

Share a file via vscode.dev link #146309

tcz717 opened this issue Mar 30, 2022 · 3 comments · Fixed by #152765
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan vscode.dev Issues related to vscode.dev
Milestone

Comments

@tcz717
Copy link

tcz717 commented Mar 30, 2022

Hi team,

I noticed it is very useful to share a file link to a remote repo. So that if we'd like to send someone a part of your code in chat or emails, they can quickly identify which code you are talking about.

Eg: we can share code via https://vscode.dev/github/microsoft/vscode/main/src/main.js?l18

I found we have permalink support for GitHub, but it will be better to have it in Azure repo and support adding code range

@lszomoru lszomoru added web Issues related to running VSCode in the web vscode.dev Issues related to vscode.dev feature-request Request for new features or functionality and removed web Issues related to running VSCode in the web labels Mar 30, 2022
@lszomoru lszomoru added this to the Backlog milestone Mar 30, 2022
@joyceerhl
Copy link
Contributor

I think this is related to the 'Share as...' menu exploration for this iteration #146672 cc @lychung7

@lychung7
Copy link
Contributor

An idea is to add a share menu item in the File menu and bring over all the Copy As.. items into here along with a new Copy vscode.dev link.

Screen Shot 2022-04-22 at 10 21 53 AM

Currently, users receive no confirmation after clicking on any of the copy link items. It would be nice to validate that the link has been copied to their clipboard.

Screen Shot 2022-04-22 at 10 22 07 AM

@peter-fb
Copy link

Please don't add new items in a right-click menu unless you also provide a setting to disable this function. There are already too many items there and it seems the clutter just increases and increases.

@alexr00 alexr00 self-assigned this Jun 16, 2022
@alexr00 alexr00 modified the milestones: Backlog, June 2022 Jun 16, 2022
alexr00 added a commit that referenced this issue Jun 21, 2022
alexr00 added a commit that referenced this issue Jun 27, 2022
* Add a share menu
Fixes #146309

* Add vscod.dev command in github extension

* Make share menu proposed

* Add share submenu into editor context

* Add proposed to editor share menu
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jun 27, 2022
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan vscode.dev Issues related to vscode.dev
Projects
Status: 📋 Backlog
8 participants
@lszomoru @tcz717 @peter-fb @joyceerhl @alexr00 @lychung7 @VSCodeTriageBot and others