Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal tabs: should reset the tab name to the default value when no name is provided #146796

Closed
bpasero opened this issue Apr 5, 2022 · 2 comments · Fixed by #148966
Closed

Terminal tabs: should reset the tab name to the default value when no name is provided #146796

bpasero opened this issue Apr 5, 2022 · 2 comments · Fixed by #148966
Assignees
@meganrogge
Labels
insiders-released Patch has been released in VS Code Insiders smoke-test-failure terminal-tabs
Milestone
May 2022

Comments

@bpasero
Copy link
Member

bpasero commented Apr 5, 2022 

  1) VSCode Smoke Tests (Electron)
       Terminal
         Terminal Tabs
           should reset the tab name to the default value when no name is provided:
     Error: Timeout: get element '.single-terminal-tab' after 20 seconds.
      at poll (D:\a\_work\1\s\test\automation\src\code.ts:120:10)
      at Code.waitForElement (D:\a\_work\1\s\test\automation\src\code.ts:264:10)
      at Terminal.assertTabExpected (D:\a\_work\1\s\test\automation\src\terminal.ts:191:5)
      at Terminal.assertSingleTab (D:\a\_work\1\s\test\automation\src\terminal.ts:126:3)
      at Context.<anonymous> (src\areas\terminal\terminal-tabs.test.ts:68:4)

Here are some builds (Windows, desktop):

And found actually one in browsers:
bpasero added a commit that referenced this issue Apr 5, 2022
@bpasero
skip flaky terminal smoke test (#146796)
a99a871
@bpasero
Copy link
Member Author

bpasero commented Apr 5, 2022

Interestingly this test seems to flake more in the new playwright based desktop tests, but I was lucky to find a web case too.

@bpasero
Copy link
Member Author

bpasero commented Apr 5, 2022

playwright-trace-1-should_reset_the_tab_name_to_the_default_value_when_no_name_is_provided.zip

@meganrogge meganrogge added this to the April 2022 milestone Apr 8, 2022
@meganrogge meganrogge modified the milestones: April 2022, May 2022 Apr 26, 2022
meganrogge added a commit that referenced this issue May 25, 2022
@meganrogge
#146796
df4458a
@meganrogge meganrogge mentioned this issue May 25, 2022
Merged
@Tyriar Tyriar removed their assignment May 25, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
insiders-released Patch has been released in VS Code Insiders smoke-test-failure terminal-tabs
Projects
None yet
Milestone
May 2022
Development

Successfully merging a pull request may close this issue.

re-enable terminal tabs test microsoft/vscode
4 participants
@bpasero @Tyriar @meganrogge @VSCodeTriageBot