Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playwright causes issues with our ipcMain validation #147301

Closed
1 of 2 tasks
bpasero opened this issue Apr 12, 2022 · 5 comments
Closed
1 of 2 tasks

playwright causes issues with our ipcMain validation #147301

bpasero opened this issue Apr 12, 2022 · 5 comments
Assignees
Labels
debt Code quality issues electron Issues and items related to Electron *out-of-scope Posted issue is not in scope of VS Code upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@bpasero
Copy link
Member

bpasero commented Apr 12, 2022

While implementing the ipcMain validation, we ran into two issues:

@bpasero bpasero added the electron Issues and items related to Electron label Apr 12, 2022
@bpasero bpasero added this to the April 2022 milestone Apr 12, 2022
@bpasero
Copy link
Member Author

bpasero commented Apr 14, 2022

This is impossible for me to reproduce in an isolated sample. Check out https://github.com/bpasero/playwright-electron, it copies a lot of stuff we do in VSCode:

  • preload script
  • vscode-file protocol
  • early ipcRenderer.invoke

To run it just node index.js and see how the URL is printed in the page.

@deepak1556 need your advice how to proceed, how can we instrument Electron app to figure out where the call is coming from?

//cc @pavelfeldman maybe you know if Playwright tampers with Electron startup somehow that could explain this. To clarify: we see a event.senderFrame.url that is the empty string in a ipcMain.handle invocation here.

@bpasero bpasero changed the title Electron ipcMain validation follow up playwright causes issues with our ipcMain validation Apr 14, 2022
@bpasero bpasero added the debt Code quality issues label Apr 14, 2022
@bpasero bpasero added this to 🗂 Backlog in Electron Integration Apr 14, 2022
@bpasero bpasero moved this from 🗂 Backlog to ✨ New in Electron Integration Apr 14, 2022
@bpasero
Copy link
Member Author

bpasero commented Apr 15, 2022

I was able to reproduce the issue on Windows at least and filed electron/electron#33800 for Electron team to look at, but it might be a playwright issue too.

@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream labels Apr 15, 2022
@bpasero
Copy link
Member Author

bpasero commented Apr 16, 2022

Nevermind, I had a bug in my sample and I was not able to reproduce and I am running out of ideas. I think to proceed we would have to instrument Electron in a way to figure out why the URL is empty. Sam might a suggestion but I do not see any loading failures.

@bpasero bpasero removed the upstream-issue-linked This is an upstream issue that has been reported upstream label Apr 16, 2022
@bpasero bpasero moved this from ✨ New to 🗂 Backlog in Electron Integration Apr 21, 2022
@bpasero bpasero moved this from 🗂 Backlog to 🏃 In Progress in Electron Integration Apr 21, 2022
@deepak1556 deepak1556 modified the milestones: April 2022, May 2022 Apr 25, 2022
@deepak1556 deepak1556 moved this from 🏃 In Progress to 🗂 Backlog in Electron Integration May 12, 2022
@bpasero bpasero modified the milestones: May 2022, Backlog May 27, 2022
@TomTravis

This comment was marked as off-topic.

@bpasero bpasero added the *out-of-scope Posted issue is not in scope of VS Code label May 31, 2022
@VSCodeTriageBot
Copy link
Collaborator

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

@bpasero bpasero moved this from 🗂 Backlog to ✔️ Done / Deferred in Electron Integration Jun 8, 2022
@bpasero bpasero removed this from ✔️ Done / Deferred in Electron Integration Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues electron Issues and items related to Electron *out-of-scope Posted issue is not in scope of VS Code upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

4 participants