New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playwright
causes issues with our ipcMain
validation
#147301
Comments
This is impossible for me to reproduce in an isolated sample. Check out https://github.com/bpasero/playwright-electron, it copies a lot of stuff we do in VSCode:
To run it just @deepak1556 need your advice how to proceed, how can we instrument Electron app to figure out where the call is coming from? //cc @pavelfeldman maybe you know if Playwright tampers with Electron startup somehow that could explain this. To clarify: we see a |
ipcMain
validation follow upplaywright
causes issues with our ipcMain
validation
I was able to reproduce the issue on Windows at least and filed electron/electron#33800 for Electron team to look at, but it might be a playwright issue too. |
Nevermind, I had a bug in my sample and I was not able to reproduce and I am running out of ideas. I think to proceed we would have to instrument Electron in a way to figure out why the URL is empty. Sam might a suggestion but I do not see any loading failures. |
This comment was marked as off-topic.
This comment was marked as off-topic.
We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider. If you wonder what we are up to, please see our roadmap and issue reporting guidelines. Thanks for your understanding, and happy coding! |
While implementing the
ipcMain
validation, we ran into two issues:ipcRenderer.postMessage
results inundefined
forevent.senderFrame
in browser process electron/electron#33722 (mitigated)sender.url
being an empty string when usingplaywright
for testingThe text was updated successfully, but these errors were encountered: