Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickOpenRecent Command Shows InputBox in quick pick #147511

Closed
TylerLeonhardt opened this issue Apr 15, 2022 · 6 comments
Closed

quickOpenRecent Command Shows InputBox in quick pick #147511

TylerLeonhardt opened this issue Apr 15, 2022 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Milestone

Comments

@TylerLeonhardt
Copy link
Member

workbench.action.quickOpenRecent

Uses "quick navigation" and is behaving as expected but it's odd there's an input box shown in the quick pick even though you'd never be able to use it.

We should hide it like Ctrl+Tab.

@TylerLeonhardt TylerLeonhardt added quick-pick Quick-pick widget issues bug Issue identified by VS Code Team member as probable bug labels Apr 15, 2022
@TylerLeonhardt TylerLeonhardt added this to the April 2022 milestone Apr 15, 2022
@TylerLeonhardt
Copy link
Member Author

Fixed in #147493

@TylerLeonhardt
Copy link
Member Author

Verification:

  1. Add following keybinding to keybindings.json:
     {    
         "key": "ctrl+m",    
         "command": "workbench.action.quickOpenRecent"    
     },    
  1. Use keybinding in VSCode

vscode will try to quick open recent files, then will try to close current workspace and open previously opened workspace.

This is expected and now you shouldn't see the inputbox/filter box in the quick pick anymore.

@rzhao271
Copy link
Contributor

So, we have to use up/down arrows to navigate through the options now? I don't see anything happen when I try typing to get to a result.

@TylerLeonhardt
Copy link
Member Author

@rzhao271 can you elaborate? After this change you shouldn't be typing anything because it's supposed to behave like Ctrl+Tab

@bpasero
Copy link
Member

bpasero commented Apr 20, 2022

To get the input field back, simply use workbench.action.openRecent instead. That is also the default command we bind to Ctrl+R.

@Vengatesh-Subbaiya
Copy link

#150683 (comment)
Please consider this scenario too.
Two different behavior for the same action will look like a bug.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants