Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: editor error placeholders #147706

Closed
2 tasks done
bpasero opened this issue Apr 19, 2022 · 1 comment
Closed
2 tasks done

Test: editor error placeholders #147706

bpasero opened this issue Apr 19, 2022 · 1 comment

Comments

@bpasero
Copy link
Member

bpasero commented Apr 19, 2022

Refs: #142875, #130971

Complexity: 2

Create Issue


The editor placeholder in case of error was updated and also shows in more cases now. The easiest is to create a HTML file with a link to a file that does not exist and click it to open as editor.

  • verify you still get asked to create the file from a modal dialog
  • if you don't create a file, the editor place holder properly conveys the error and offers the same action as the dialog
  • if you create the missing file in this flow, the editor place holder goes away

Alternatively you can:

  • open a file
  • close VSCode
  • delete the file
  • start VSCode
  • the editor restores but with the error placeholder since the file was deleted on disk
@TylerLeonhardt
Copy link
Member

Works well!

@TylerLeonhardt TylerLeonhardt removed their assignment Apr 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants