What should happen when on a read-only filesystem?

[TylerLeonhardt]

Testing #147706

using an untitled html file:

<a href="/doesnotexit.txt"></a>

I think this makes sense because it's trying to save to the root of the file system at /doesnotexist.txt but I wanted to open this anyway just in case because it throws that error and then closes the editor in the background which is maybe not as consistent of this new "error when not exist" flow.

[bpasero]

We have no real way to figure out if the

[bpasero]

From no to aye in 5 minutes!

[bpasero]

Oh, had to revert, not easy to fix: as part of the action flow, the action may decide to open another editor (that actually happens as part of the create file flow). If we await that action, we fail to open that editor because we still think we are in an error case.

So I am actually proceeding in the background to open the place holder without waiting for the action to finish and thus I cannot detect whether the action results in an error or not. As such, I simply always consider the action to have succeeded in a way that I do not need to show the place holder:

vscode/src/vs/workbench/browser/parts/editor/editorPanes.ts

Lines 189 to 194 in 0290856

	const result = errorAction.run();
	if (result instanceof Promise) {
	result.catch(error => this.dialogService.show(Severity.Error, toErrorMessage(error)));
	}
	errorHandled = true; // consider the error as handled!

tl;dr;: if you press any button in the dialog other than "Cancel", no place holder shows because I assume you have dealt with the error, even if that fails.