Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve workspace text search with notebook editors #148068

Closed
roblourens opened this issue Apr 25, 2022 · 1 comment
Closed

Improve workspace text search with notebook editors #148068

roblourens opened this issue Apr 25, 2022 · 1 comment
Assignees
Labels
feature-request Request for new features or functionality search Search widget and operation issues

Comments

@roblourens
Copy link
Member

roblourens commented Apr 25, 2022

Made some improvements in #95275, this issue is to continue the work

  • When doing a text search with an open notebook editor, sync find matches back into the search view, same as it works for text editors

Notes

  • The SearchModel needs to listen to events for notebook editors, and bind to a notebook editor, not a text model as in normal text editors, because this is where find is implemented in notebooks.
  • The SearchModel needs to be fully aware of notebook cells. Match ids need to include the match cell fragment so they don't conflict between cells
@roblourens roblourens added feature-request Request for new features or functionality search Search widget and operation issues labels Apr 25, 2022
@roblourens roblourens added this to the May 2022 milestone Apr 25, 2022
@roblourens roblourens self-assigned this Apr 25, 2022
@roblourens roblourens modified the milestones: May 2022, June 2022 Jun 1, 2022
@roblourens roblourens modified the milestones: June 2022, July 2022 Jun 29, 2022
@roblourens roblourens modified the milestones: July 2022, August 2022 Jul 20, 2022
@roblourens roblourens assigned andreamah and unassigned roblourens Sep 28, 2022
@andreamah andreamah modified the milestones: October 2022, November 2022 Oct 24, 2022
@andreamah andreamah removed this from the November 2022 milestone Nov 29, 2022
@andreamah
Copy link
Contributor

Merging with #164926

@andreamah andreamah removed this from the February 2023 milestone Feb 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality search Search widget and operation issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants