Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syncing UI State with multiple moved view containers will break #148363

Closed
sbatten opened this issue Apr 28, 2022 · 2 comments · Fixed by #148450
Closed

Syncing UI State with multiple moved view containers will break #148363

sbatten opened this issue Apr 28, 2022 · 2 comments · Fixed by #148450
Assignees
@sbatten
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues verified Verification succeeded workbench-views Workbench view issues
Milestone
April 2022

Comments

@sbatten
Copy link
Member

sbatten commented Apr 28, 2022 •
edited

Issue Type: Bug

Repro using Profiles Feature

  1. Create a new user data dir and launch VS Code.

  2. Move timeline to its own container in the activity bar

  3. Move search container to secondary side bar

  4. Export the profile

  5. Create a new user data dir and launch VS Code.

  6. Import the profile

🐛 => the timeline container will not be created and timeline will remain in the explorer view

cc @sandy081

VS Code version: Code - Insiders 1.67.0-insider (410fe0f, 2022-04-27T05:15:39.871Z)
OS version: Windows_NT x64 10.0.22593
Restricted Mode: No
@sbatten sbatten changed the title Syncing UI State with multiple moved views breaks Syncing UI State with multiple moved view containers will break Apr 28, 2022
@sbatten sbatten self-assigned this Apr 28, 2022
@sbatten sbatten added layout General VS Code workbench layout issues workbench-views Workbench view issues labels Apr 28, 2022
@gjsjohnmurray
Copy link
Contributor

Is this #148320?

@sbatten
Copy link
Member Author

sbatten commented Apr 28, 2022

unfortunately no, this another case where we break with similar symptoms :(

@sandy081 sandy081 mentioned this issue Apr 29, 2022
Closed
@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Apr 29, 2022
sbatten added a commit that referenced this issue Apr 29, 2022
@sbatten
fixes #148363
51895f6 
skip writing to disk cache when a storage write contains container moves
precisely this matters if some of the containers are generated as a
result of view movement
@sbatten sbatten mentioned this issue Apr 29, 2022
Merged
@sbatten sbatten added this to the April 2022 milestone Apr 29, 2022
@sbatten sbatten added the candidate Issue identified as probable candidate for fixing in the next release label Apr 29, 2022
sbatten added a commit that referenced this issue May 2, 2022
@sbatten
fixes #148363 (#148450)
72ddb69 
skip writing to disk cache when a storage write contains container moves
precisely this matters if some of the containers are generated as a
result of view movement
@sbatten sbatten closed this as completed in 46257aa May 2, 2022
@sandy081 sandy081 added the verified Verification succeeded label May 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues verified Verification succeeded workbench-views Workbench view issues
Projects
None yet
Milestone
April 2022
4 participants
@sbatten @gjsjohnmurray @sandy081 and others