Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when connecting to a Codespace #148414

Closed
joaomoreno opened this issue Apr 29, 2022 · 7 comments
Closed

Error when connecting to a Codespace #148414

joaomoreno opened this issue Apr 29, 2022 · 7 comments
Assignees
@TylerLeonhardt
Labels
bug Issue identified by VS Code Team member as probable bug github-authentication Issues with the GitHub Authentication extension insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
May 2022

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Apr 29, 2022 •
edited

image

cc @alexr00 @TylerLeonhardt
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug github Github extension labels Apr 29, 2022
@joaomoreno joaomoreno added this to the April 2022 milestone Apr 29, 2022
@joaomoreno joaomoreno self-assigned this Apr 29, 2022
@joaomoreno joaomoreno changed the title GitHub Authentication extension should always run on the same side as Git Error when connecting to a Codespace Apr 29, 2022
@joaomoreno
Copy link
Member Author

Summary:

  • This now happens because GHPR now depends on GitHub Authentication
  • Each extension runs on different locations (one UI, one workspace)
  • @alexdima suggests to use api: 'none' in github-authentication to make the dependency an activation dependency only

@joaomoreno joaomoreno modified the milestones: April 2022, May 2022 Apr 29, 2022
@joaomoreno joaomoreno added github-authentication Issues with the GitHub Authentication extension and removed github Github extension labels Apr 29, 2022
@joaomoreno
Copy link
Member Author

joaomoreno commented Apr 29, 2022 •
edited

In order not to push a new change at the last day of endgame, @alexr00 will simply revert the dependency today and we'll push a proper fix next week.

joaomoreno added a commit that referenced this issue Apr 29, 2022
@joaomoreno
fixes #148414
18e03cc
alexr00 added a commit to microsoft/vscode-pull-request-github that referenced this issue Apr 29, 2022
@alexr00
Remove dependency on GitHub Authentication
df4a58c 
Part of microsoft/vscode#148414
@alexr00
Copy link
Member

alexr00 commented Apr 29, 2022

Dependency removed and a new GHPRI pre-release is in the works.

@TylerLeonhardt
Copy link
Member

Sorry, what is api: none?

@alexr00
Copy link
Member

alexr00 commented Apr 29, 2022 •
edited

It indicates that the extension doesn't export extension API and that any dependencies on it should be resolved based on the existence and enablement of the extension, not based on it being in the same extension host and exporting API. @alexdima suggested it as it will enable GHPRI to have a dependency on GitHub Authentication without requiring that the two be in the same extension host. Use: 18e03cc

@TylerLeonhardt
Copy link
Member

Very cool. Thanks for the context!

@alexdima
Copy link
Member

(you can read more about api:none here)

@joyceerhl joyceerhl added the verified Verification succeeded label Jun 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TylerLeonhardt TylerLeonhardt

Labels
bug Issue identified by VS Code Team member as probable bug github-authentication Issues with the GitHub Authentication extension insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
May 2022
Development

No branches or pull requests
6 participants
@joaomoreno @TylerLeonhardt @alexdima @joyceerhl @alexr00 and others