Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add Configuration..." to add a debug configuration uses type: "node" while debug provider uses type: "node-terminal" #149257

Closed
segevfiner opened this issue May 11, 2022 · 2 comments

Comments

@segevfiner
Copy link
Contributor

Does this issue occur when all extensions are disabled?: No

  • VS Code Version: 1.67.1
  • OS Version: macOS 12.3.1 arm64

Steps to Reproduce:

  1. Open some Node.js project.

  2. Add a launch configuration by using the "Add configuration..." floating button when launch.json is opened.
    image

  3. Add a launch configuration by opening the quick pick (Ctrl/Cmd+P), typing "debug", selecting "Node.js...", and clicking with the mouse on the cogwheel in one of the suggested configurations.
    image
    image

The configuration added by "Add configuration..." uses "type": "node", while the one added by the debug quick pick uses "type": "node-terminal".

I couldn't find clear docs showing the difference between them or when you should use one or the other, and I find it weird that those two flows produce inconsistent results.

There is also the "pwa-node" (And possibly "pwa-node-terminal"?) debug/launch types which I'm also not sure if should be used or not, and I couldn't find any docs for them either.

@roblourens
Copy link
Member

roblourens commented May 11, 2022

node-terminal is used when running a program in a "javascript debug terminal" that automatically attaches to any node program. node is what you would use in a launch.json. pwa- prefixed types are sort of a historical leftover from the old node debugger implementation that we had a few years ago. pwa-node is now the same as node by default. cc @connor4312

@roblourens roblourens removed their assignment May 11, 2022
@segevfiner
Copy link
Contributor Author

@roblourens Might want to add this to the main VS Code documentation. Including a recommendation for what users should use.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants