Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default the workspace name to the folder name first added. #149531

Closed
JohnLukeBentley opened this issue May 14, 2022 · 0 comments · Fixed by #150535
Closed

Default the workspace name to the folder name first added. #149531

JohnLukeBentley opened this issue May 14, 2022 · 0 comments · Fixed by #150535
Assignees
@bpasero
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Milestone
May 2022

Comments

@JohnLukeBentley
Copy link

I suggest we default the workspace name to the folder name first added added to the workspace.

Current behaviour.

  1. File > Open a Folder ... > C:\foo. This gets added to VSC.
  2. File > Open a Folder ... > C:\bar. This gets added to the current (unsaved and "untitled") workspace. Note bar is listed after foo even though it is lexically higher. That is, folders get appended in addition order (this is desirable).
  3. File > Save workspace as ... > {The Save Workspace dialog is opened and the default File Name is workspace.code-workspace}. Users therefore have an opportunity to change the basename of workspace.code-workspace to a string of their choosing.

Suggested behaviour:

  1. File > Save workspace as ... > {The Save Workspace dialog is opened and the default File Name is foo.code-workspace}.

The first folder added to the workspace is conceptually, usually, the master to which subsequently added folders are conceptually subservient. At least this is true in my case but I'd be surprised if many others didn't also operate this way.
@bpasero bpasero added this to the May 2022 milestone May 27, 2022
@bpasero bpasero added feature-request Request for new features or functionality workbench-multiroot Multi-root (multiple folders) issues labels May 27, 2022
bpasero added a commit that referenced this issue May 27, 2022
@bpasero
Default the workspace name to the folder name first added. (fix #149531)
ab66ce7
@bpasero bpasero mentioned this issue May 27, 2022
Merged
bpasero added a commit that referenced this issue May 27, 2022
@bpasero
Default the workspace name to the folder name first added. (fix #149531…
caa1479 
…) (#150535)
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label May 27, 2022
@bpasero bpasero added the verification-needed Verification of issue is requested label May 28, 2022
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 30, 2022
@stuartleeks stuartleeks added the verified Verification succeeded label May 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Milestone
May 2022
Development

Successfully merging a pull request may close this issue.

Default the workspace name to the folder name first added microsoft/vscode
4 participants
@bpasero @stuartleeks @JohnLukeBentley @VSCodeTriageBot