Cleanup data transfer types #149774
Merged
Cleanup data transfer types #149774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change attempts to clean up our internal data transfer types
- Replace `IDataTransfer` (which was just an alias for map) with a `VSDataTransfer` helper class.
This lets us add helpers and also restrict what you can do on a datatransfer
- Move `DataTransferDTO` types into `protocol`
- Move `DataTransferTypeConverter` into `typeConvert`
- Don't return internal types to ext host callers
For example, previously we leaked `IDataTransfer` out into providers / controllers. Instead we should always return an instance of `vscode.DataTransfer` to extensions
roblourens
approved these changes
May 23, 2022
alexr00
approved these changes
May 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change attempts to clean up our internal data transfer types
Replace
IDataTransfer(which was just an alias for map) with aVSDataTransferhelper class.This lets us add helpers and also restrict what you can do on a datatransfer
Move
DataTransferDTOtypes intoprotocolMove
DataTransferTypeConverterintotypeConvertDon't return internal types to extension callers
For example, previously we leaked
IDataTransferout into providers / controllers. Instead we should always return a real instance ofvscode.DataTransferto extensionsMark
vscode.DataTransfer._itemsas privateExtensions should not be able to access this field