Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot auth if vscode.dev is in iframe #150152

Open
DawidMazur opened this issue May 23, 2022 · 4 comments
Open

Cannot auth if vscode.dev is in iframe #150152

DawidMazur opened this issue May 23, 2022 · 4 comments
Assignees
Labels
authentication Issues with the Authentication platform feature-request Request for new features or functionality
Milestone

Comments

@DawidMazur
Copy link

ADD ISSUE DESCRIPTION HERE

Hi
I noticed that there is a problem with github authentication when the page is in iframe, the external window is displayed for a while, it disappears but authentication doesn't go any further.

Tested on localhost (by xampp with standard configuration)

Version: 1.67.2
Commit: c3511e6
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/101.0.4951.67 Safari/537.36
Embedder: vscode.dev

@TylerLeonhardt
Copy link
Member

Yeah embedding vscode.dev in an iframe is not a supported scenario for us at this time.

We may explore this in the future but it would take a considerable amount of work to get right.

cc @bamurtaugh do we have a issue around this? Otherwise, I can keep this open.

@TylerLeonhardt TylerLeonhardt added authentication Issues with the Authentication platform feature-request Request for new features or functionality labels May 25, 2022
@TylerLeonhardt TylerLeonhardt added this to the Backlog milestone May 25, 2022
@bamurtaugh
Copy link
Member

@TylerLeonhardt Let's keep this issue open - I don't think we have another.

@claranceliberi
Copy link

Nuxt team has been working on nuxt-dev-tools project, we are trying to embed vscode.dev in our devtools nuxt/devtools#38 so that users can edit codes directly in the browser and get all the vs code benefits while debugging or developing.

At the moment, this can't be achieved with vscode.dev due to this issue. we would like to know the way forwad

@Sandros94
Copy link

Sandros94 commented Jun 18, 2023

Nuxt team has been working on nuxt-dev-tools project, we are trying to embed vscode.dev in our devtools nuxt/devtools#38 so that users can edit codes directly in the browser and get all the vs code benefits while debugging or developing.

At the moment, this can't be achieved with vscode.dev due to this issue. we would like to know the way forwad

Just to provide two simple use cases for this:

  • Developer on a single-screen machine (like a laptop): they have both vscode and browser open and usually they need to alt-tab back and forth to check things. Embedding vscode inside an iframe of nuxt-devtools we could have vscode floating in our browser window and speed up the development.
  • Developer on the go: the developer only has a windows desktop and a mobile tablet, since there is no direct support for code-server on windows, vscode tunnel is the only other option. They could open a tunnel connection for both vscode and node port, and opening up only the second link, while being able to use vscode inside the iframe in nuxt-devtools. Having only one browser tab for this job would greatly improve the battery consumption on mobile devices and let them develop longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication Issues with the Authentication platform feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants