Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Issues In Dark High Contrast Theme When Using Source Control #150595

Closed
d-01 opened this issue May 28, 2022 · 2 comments · Fixed by #150880
Closed

Accessibility Issues In Dark High Contrast Theme When Using Source Control #150595

d-01 opened this issue May 28, 2022 · 2 comments · Fixed by #150880
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@d-01
Copy link

d-01 commented May 28, 2022

Issue Type: Bug

Steps to reproduce:

  1. Activate Dark High Contrast theme.
  2. Open Explorer panel (Ctrl+Shift+E).
  3. Create new workspace in an empty folder.
  4. Add a bunch of files (can be empty).
  5. >Git: Initialize Repository
  6. >Git: Stage All Changes

Expected result:

  1. All labels are clearly visible.
    • Contrast: no less then 4.5 (Level AA, according to WCAG 2.1)

Actual result:

  1. Poor contrast on tab labels, Explorer items and Open Editors items.
    • Text color: rgb(27, 82, 37)
    • Background: rgb(0, 0, 0)
    • Contrast: 2.28 (according to dev tools and contrast-ratio.com online tool).

Screenshot:

image

VS Code version: Code 1.67.2 (c3511e6, 2022-05-17T18:15:52.058Z)
OS version: Windows_NT x64 6.1.7601
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM)2 Quad CPU Q6600 @ 2.40GHz (4 x 2400)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: unavailable_off
opengl: enabled_on
rasterization: unavailable_off
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 6.00GB (1.67GB free)
Process Argv --crash-reporter-id a8433a52-a6c8-40eb-8636-eec7af64dfe2
Screen Reader no
VM 0%
Extensions: none
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
pythonvspyl392:30443607
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
pythonvsnew555:30457759
vscscmwlcmt:30465135
cppdebug:30492333
vsclangdc:30486549

@lszomoru
Copy link
Member

@daviddossett, could you please take a look? Thank you!

@lszomoru lszomoru added bug Issue identified by VS Code Team member as probable bug git GIT issues labels May 30, 2022
daviddossett added a commit that referenced this issue May 31, 2022
@daviddossett
Copy link
Contributor

Thanks for the catch, @d-01. Fixed with #150880

CleanShot 2022-05-31 at 10 00 45@2x

daviddossett added a commit that referenced this issue May 31, 2022
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label May 31, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the May 2022 milestone May 31, 2022
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 1, 2022
@mjbvz mjbvz added the verified Verification succeeded label Jun 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants