Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension sponsoring #150703

Merged
merged 7 commits into from May 30, 2022
Merged

Extension sponsoring #150703

merged 7 commits into from May 30, 2022

Conversation

sandy081
Copy link
Member

Fixes #107482

Implement extension sponsoring

@sandy081 sandy081 enabled auto-merge May 30, 2022 12:05
@sandy081 sandy081 self-assigned this May 30, 2022
@sandy081 sandy081 requested a review from isidorn May 30, 2022 12:05
@VSCodeTriageBot VSCodeTriageBot added this to the May 2022 milestone May 30, 2022
@@ -2841,75 +2885,67 @@ export const extensionButtonProminentHoverBackground = registerColor('extensionB
hcLight: null
}, localize('extensionButtonProminentHoverBackground', "Button background hover color for actions extension that stand out (e.g. install button)."));

registerColor('extensionSponsorButton.background', { light: '#E94AAA', dark: '#E90A91', hcDark: null, hcLight: '#E94AAA' }, localize('extensionSponsorButton.background', "Background color for extension sponsor button."), true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @aeschli for new color names

@@ -517,6 +517,10 @@ export const schema: IJSONSchema = {
}
}
},
sponsor: {
description: nls.localize('vscode.extension.contributes.sponsorLink', "The website URL from where others can sponosor the extension."),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest the following wording
"URL from where users can sponsor your extension. If a URL is provided a Sponsor button will get rendered in extension details page. Example value: https://github.com/sponsors/nvaccess"

@sandy081 sandy081 merged commit 6faebbe into main May 30, 2022
@sandy081 sandy081 deleted the sandy081/extensionSponsorhip branch May 30, 2022 12:19
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore integration between extensions view and GitHub Sponsors
3 participants