Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process explorer: indicate extension host better? #150820

Closed
bpasero opened this issue May 31, 2022 · 4 comments · Fixed by #154043
Closed

Process explorer: indicate extension host better? #150820

bpasero opened this issue May 31, 2022 · 4 comments · Fixed by #154043
Assignees
@deepak1556 @alexdima
Labels
extension-host Extension host issues insiders-released Patch has been released in VS Code Insiders sandbox Running VSCode in a node-free environment
Milestone
July 2022

Comments

@bpasero
Copy link
Member

bpasero commented May 31, 2022

Testing #150753

It looks like now it is harder to find the ext host process in the process explorer. I think we often ask users to look at that process so maybe we need to tweak process explorer to indicate the ext host better:

image
@bpasero bpasero added sandbox Running VSCode in a node-free environment extension-host Extension host issues labels Jun 8, 2022
@alexdima alexdima added this to the June 2022 milestone Jun 13, 2022
@deepak1556 deepak1556 modified the milestones: June 2022, July 2022 Jun 30, 2022
bpasero added a commit that referenced this issue Jul 4, 2022
@bpasero
Process explorer: indicate extension host better (fix #150820)
f2e9316
@bpasero bpasero mentioned this issue Jul 4, 2022
Merged
bpasero added a commit that referenced this issue Jul 4, 2022
@bpasero
Process explorer: indicate extension host better (fix #150820) (#154043)
3559a3c
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jul 4, 2022
bpasero added a commit that referenced this issue Jul 8, 2022
@bpasero
Process explorer: indicate extension host better (fix #150820 on wind…
df1e03e 
…ows too)
@bpasero
Copy link
Member Author

bpasero commented Jul 8, 2022

Turns out this was not working on windows: looks like on windows, arguments passed to a process get lowercased, so --vscode-utility-kind=extensionHost became --vscode-utility-kind=extensionhost. I will push a fix to just pass --vscode-utility-kind=extension-host

That said, we still seem to pass in --type=extensionHost:

vscode/src/vs/platform/extensions/electron-main/extensionHostStarter.ts

Line 325 in 3104db4

const args: string[] = ['--type=extensionHost', '--skipWorkspaceStorageLock'];

And I am not sure that is needed anymore?

@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 8, 2022
bpasero added a commit that referenced this issue Jul 8, 2022
@bpasero
Process explorer: indicate extension host better (fix #150820 on wind…
ef14540 
…ows too) (#154454)
@deepak1556
Copy link
Contributor

--type=extensionHost is redundant, because chromium already attaches --type=utility when launching the process and it cannot be overwritten.

@bpasero
Copy link
Member Author

bpasero commented Jul 8, 2022

We probably need to keep it until we have removed the other way of launching...

@deepak1556
Copy link
Contributor

Oh yeah, missed that.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deepak1556 deepak1556

@alexdima alexdima

Labels
extension-host Extension host issues insiders-released Patch has been released in VS Code Insiders sandbox Running VSCode in a node-free environment
Projects
None yet
Milestone
July 2022
Development

Successfully merging a pull request may close this issue.

Process explorer: indicate extension host better (fix #150820) microsoft/vscode
4 participants
@bpasero @deepak1556 @alexdima @VSCodeTriageBot