Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align auth scopes between builtin GitHub extension, GHPRI, and GitHub Repositories #151045

Merged
merged 1 commit into from Jun 1, 2022
Merged

Align auth scopes between builtin GitHub extension, GHPRI, and GitHub Repositories #151045

merged 1 commit into from Jun 1, 2022

Conversation

joyceerhl
Copy link
Contributor

This PR fixes #151044

@joyceerhl joyceerhl enabled auto-merge (squash) June 1, 2022 22:36
@joyceerhl joyceerhl self-assigned this Jun 1, 2022
@joyceerhl joyceerhl requested a review from joaomoreno June 1, 2022 22:36
@VSCodeTriageBot VSCodeTriageBot added this to the May 2022 milestone Jun 1, 2022
TylerLeonhardt
TylerLeonhardt approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause users of this extension to have to relog in... but the one time pain is worth it for scope alignment.

That said, if you are feeling invested, you could add the same logic that you did to remote hub to "fallback" to the old scope list

@joyceerhl joyceerhl merged commit b9b2862 into main Jun 1, 2022
@joyceerhl joyceerhl deleted the dev/joyceerhl/github-scopes branch June 1, 2022 23:50
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

@joaomoreno joaomoreno Awaiting requested review from joaomoreno

Assignees

@joyceerhl joyceerhl

Labels
None yet
Projects
None yet
Milestone
May 2022
Development

Successfully merging this pull request may close these issues.

Align GitHub and GitHub Repositories extension scopes
3 participants
@joyceerhl @TylerLeonhardt @VSCodeTriageBot