Fix releasing alt sometimes not hiding locked hovers #151185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CompositeMouseTracker.isMouseIn's initial state is now true, this means releasing alt without moving the mouse will not hide the hover - The current hover options are now only cleared when the hover being disposed is the active hover, this was the main cause of the problem because if current hover options is undefined while there is an active hover weird things could happen Fixes #150842
aeschli
approved these changes
Jun 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
releasing alt without moving the mouse will not hide the hover
disposed is the active hover, this was the main cause of the problem because
if current hover options is undefined while there is an active hover weird
things could happen
Fixes #150842